Skip to content

Make boolean checks explicit without changing how the app behaves [WPB-22420] #21292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
screendriver wants to merge 1 commit into
base: dev
Choose a base branch
from

chore(webapp): continue strict-boolean migration with explicit nullis…

61d92ac
Select commit
Loading
Failed to load commit list.
Draft

Make boolean checks explicit without changing how the app behaves [WPB-22420] #21292

chore(webapp): continue strict-boolean migration with explicit nullis…
61d92ac
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 13, 2026 in 58s

Quality Gate passed

Issues
38 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.4% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 979 in libraries/core/src/account.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk56UudVs6-nGpXG&open=AZ4chk56UudVs6-nGpXG&pullRequest=21292

Check warning on line 203 in apps/webapp/src/script/components/HistoryExport/HistoryExport.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlJ3UudVs6-nGpXh&open=AZ4chlJ3UudVs6-nGpXh&pullRequest=21292

Check warning on line 109 in apps/webapp/src/script/components/Modals/UserModal/UserModal.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlAtUudVs6-nGpXQ&open=AZ4chlAtUudVs6-nGpXQ&pullRequest=21292

Check warning on line 55 in apps/webapp/src/script/components/Cells/ShareModal/shareModalSerializer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlJmUudVs6-nGpXg&open=AZ4chlJmUudVs6-nGpXg&pullRequest=21292

Check warning on line 279 in apps/server/Server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlLBUudVs6-nGpXi&open=AZ4chlLBUudVs6-nGpXi&pullRequest=21292

Check warning on line 149 in apps/webapp/src/script/components/UserSearchableList/UserSearchableList.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlG9UudVs6-nGpXb&open=AZ4chlG9UudVs6-nGpXb&pullRequest=21292

Check warning on line 75 in apps/webapp/src/script/components/Modals/ModalComponent/ModalComponent.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk_YUudVs6-nGpXL&open=AZ4chk_YUudVs6-nGpXL&pullRequest=21292

Check warning on line 139 in apps/webapp/src/script/components/MessagesList/MessageList.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlEzUudVs6-nGpXZ&open=AZ4chlEzUudVs6-nGpXZ&pullRequest=21292

Check warning on line 98 in libraries/core/src/messagingProtocols/mls/eventHandler/events/messageAdd/messageAdd.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk2XUudVs6-nGpXC&open=AZ4chk2XUudVs6-nGpXC&pullRequest=21292

Check warning on line 49 in apps/webapp/src/script/components/Conversation/ReadOnlyConversationMessage/ReadOnlyConversationMessage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk7ZUudVs6-nGpXH&open=AZ4chk7ZUudVs6-nGpXH&pullRequest=21292

Check warning on line 58 in apps/webapp/src/script/components/Modals/QualityFeedbackModal/QualityFeedbackModal.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk_DUudVs6-nGpXK&open=AZ4chk_DUudVs6-nGpXK&pullRequest=21292

Check warning on line 251 in apps/webapp/src/script/components/Cells/ShareModal/CellsShareExpirationFields.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlJXUudVs6-nGpXf&open=AZ4chlJXUudVs6-nGpXf&pullRequest=21292

Check failure on line 99 in libraries/api-client/src/notification/notificationApi/notificationApi.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk1qUudVs6-nGpXB&open=AZ4chk1qUudVs6-nGpXB&pullRequest=21292

Check warning on line 228 in apps/webapp/src/script/components/MessagesList/Message/ContentMessage/asset/VideoAsset/VideoAsset.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlCJUudVs6-nGpXV&open=AZ4chlCJUudVs6-nGpXV&pullRequest=21292

Check warning on line 60 in apps/webapp/src/script/components/EmojiPicker/EmojiPicker.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlJBUudVs6-nGpXe&open=AZ4chlJBUudVs6-nGpXe&pullRequest=21292

Check warning on line 225 in apps/webapp/src/script/components/InputBar/useMessageHandling/useMessageSend/useMessageSend.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk-MUudVs6-nGpXJ&open=AZ4chk-MUudVs6-nGpXJ&pullRequest=21292

Check warning on line 141 in apps/webapp/src/script/components/Modals/ModalComponent/ModalComponent.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk_YUudVs6-nGpXM&open=AZ4chk_YUudVs6-nGpXM&pullRequest=21292

Check warning on line 61 in apps/webapp/src/script/components/Modals/PrimaryModal/PrimaryModalShell/PrimaryModalShell.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk_sUudVs6-nGpXN&open=AZ4chk_sUudVs6-nGpXN&pullRequest=21292

Check warning on line 190 in apps/webapp/src/script/components/Modals/UserModal/UserModal.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlAtUudVs6-nGpXR&open=AZ4chlAtUudVs6-nGpXR&pullRequest=21292

Check warning on line 866 in libraries/core/src/account.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk56UudVs6-nGpXF&open=AZ4chk56UudVs6-nGpXF&pullRequest=21292

Check warning on line 237 in apps/webapp/src/script/components/Modals/DetailViewModal/index.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlARUudVs6-nGpXP&open=AZ4chlARUudVs6-nGpXP&pullRequest=21292

Check warning on line 143 in apps/webapp/src/script/components/MessagesList/utils/virtualizedMessagesGroup.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chlEFUudVs6-nGpXY&open=AZ4chlEFUudVs6-nGpXY&pullRequest=21292

Check warning on line 417 in libraries/api-client/src/apiClient.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chksSUudVs6-nGpW-&open=AZ4chksSUudVs6-nGpW-&pullRequest=21292

Check warning on line 228 in libraries/api-client/src/apiClient.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using nullish coalescing operator (`??=`) instead of an assignment expression, as it is simpler to read. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chksSUudVs6-nGpW9&open=AZ4chksSUudVs6-nGpW9&pullRequest=21292

Check warning on line 400 in libraries/api-client/src/cells/cellsApi.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=wireapp_wire-webapp&issues=AZ4chk0IUudVs6-nGpW_&open=AZ4chk0IUudVs6-nGpW_&pullRequest=21292
View more details on SonarQubeCloud