Repository navigation
chore: require Python 3.8 on 3.x, since ipyvue 3.1.0 does not import on 3.7 - #348
Merged
Merged
Conversation
ipyvuetify 3.x depends on ipyvue>=3.0.0, and ipyvue 3.1.0 cannot be imported on Python 3.7 (it uses an assignment expression). So ipyvuetify on Python 3.7 now installs, but import ipyvuetify fails, and the test (3.7) CI job fails for that reason. Python 3.7 has been end of life since June 2023, so the 3.x line drops it: requires-python >=3.8, no 3.6 and 3.7 classifiers, and no 3.7 CI job. The 1.x line keeps its Python support. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipyvuetify 3.x now needs Python 3.8 or newer, because its dependency ipyvue 3.1.0 no longer imports on Python 3.7.
Problem
ipyvuetify 3.x depends on
ipyvue>=3.0.0. ipyvue 3.1.0 uses an assignment expression (:=), which Python 3.7 cannot parse.So on Python 3.7, pip installs ipyvuetify and ipyvue 3.1.0, and then
import ipyvuetifyfails with aSyntaxError.This repository's
test (3.7)CI job now fails for that reason, also on unrelated PRs such as #346.Python 3.7 has been end of life since June 2023.
Change
pyproject.tomlsetsrequires-python = ">=3.8"and drops the Python 3.6 and 3.7 classifiers..github/workflows/test.ymldrops Python 3.7.Validation
test (3.7), which failed infrom ipyvue import VueWidgetwithSyntaxErroratipyvue/esm.py:91.Gaps
Align results
Crossreview results
Round 1, by astra and gpt-6.1-sol, on both companion PRs together. Neither found a defect. Both noted older things this PR does not change: some ipyvue UI-test skip messages still name old Python versions, and the setuptools minimum in ipyvuetify is out of date.
🤖 Generated with Claude Code