Repository navigation
chore: require Python 3.8, since ipyvue 3.1.0 does not import on 3.7 - #117
Merged
Merged
Conversation
maartenbreddels
marked this pull request as ready for review
October 5, 2026 19:42
ipyvue 3.1.0 uses an assignment expression (:=) in ipyvue/esm.py, which Python 3.7 cannot parse, but it declares no requires-python. pip on Python 3.7 therefore installs 3.1.0, and then import ipyvue fails with a SyntaxError. CI already tests only 3.8 and newer, and Python 3.7 has been end of life since June 2023. With python_requires, pip on 3.7 skips the next release. 3.1.0 itself has no such metadata: only yanking it on PyPI keeps 3.7 users on 3.0.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maartenbreddels
force-pushed
the
chore/require-python-38
branch
from
October 6, 2026 08:07
2ae1b60 to
543869e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipyvue now declares that it needs Python 3.8 or newer, because ipyvue 3.1.0 already does not import on Python 3.7.
Problem
ipyvue 3.1.0 uses an assignment expression (
:=) inipyvue/esm.py, line 91. Python 3.7 cannot parse it.The 3.1.0 package declares no minimum Python version, so pip on Python 3.7 still installs it.
Then
import ipyvuefails with aSyntaxError, and so doesimport ipyvuetify, which depends onipyvue>=3.0.0.ipyvuetify's CI showed it: its
test (3.7)job fails with ipyvue 3.1.0.Python 3.7 has been end of life since June 2023, and CI here already tests only 3.8 and newer.
Change
setup.pysetspython_requires=">=3.8".Validation
ast.parsewithfeature_version=(3, 7)). 3.1.0 fails atipyvue/esm.py:91. 1.13.0 parses.SyntaxError.Gaps
Align results
Crossreview results
Round 1, by astra and gpt-6.1-sol, on both companion PRs together. Neither found a defect. Both noted older things this PR does not change: some ipyvue UI-test skip messages still name old Python versions, and the setuptools minimum in ipyvuetify is out of date.
🤖 Generated with Claude Code