Skip to content

fix: preserve occupied Meta/WhatsApp referral attributes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Atroci merged 1 commit into from
Sep 15, 2026
Merged

fix: preserve occupied Meta/WhatsApp referral attributes #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions integrations/chatwoot/src/referral.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,11 @@ export function mergeMetaWhatsAppReferralAttributes(
if (options?.consentState !== 'granted') return base;

const candidate = metaWhatsAppReferralAttributes(referral);
const hasExistingReferral = Object.keys(base).some(
(key) => key.startsWith(META_WHATSAPP_REFERRAL_ATTRIBUTE_PREFIX) && hasValue(base[key]),
const hasExistingReferral = META_WHATSAPP_REFERRAL_FIELDS.some(
(key) => Object.prototype.hasOwnProperty.call(
base,
`${META_WHATSAPP_REFERRAL_ATTRIBUTE_PREFIX}${key}`,
),
);
if (hasExistingReferral) return base;

Expand Down
8 changes: 8 additions & 0 deletions integrations/chatwoot/tests/referral.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,11 @@ test('preserves an existing flat referral snapshot without mixing messages', ()
assert.equal(result.clicktrail_referral_ctwa_clid, undefined);
assert.equal(result.clicktrail_referral_arbitrary, undefined);
});

test('treats a recognized flat referral key as occupied regardless of value type', () => {
const existing = { clicktrail_referral_source_id: 42 };
assert.deepEqual(
mergeMetaWhatsAppReferralAttributes(existing, referral, { consentState: 'granted' }),
existing,
);
});
Loading