RSDK-13980: Enable cli windows tests by allisonschiang · Pull Request #6022 · viamrobotics/rdk

allisonschiang · 2026-05-18T20:33:28Z

This PR enables cli in the windows testing suite and then fixes some of the tests to make it work for windows. This PR only fixes tests, not broken implementations, and I added skips to tests with the jira ticket documenting that the original command doesn't work.

Testing using the github workflow that enables it:
https://github.com/viamrobotics/rdk/actions/runs/26180155038

… check

…onfig+TestLocalBuild+test_copy_python_template platform-aware

…ror substring match Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…e test infra failures Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…est skip Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…55 dir Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…oken tunnel test, restore gitattributes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…evert noisy copy_local close Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

allisonschiang · 2026-05-20T17:51:33Z

@@ -0,0 +1 @@
+*.md text eol=lf


Windows GitHub Actions runners default to core.autocrlf=true, which converts LF → CRLF on checkout. CRLF adds 1 byte per line. So a 167-char file checked out on Linux becomes ~171 chars on Windows, and the test fails the byte-count assertions

windows test will fail without it

allisonschiang · 2026-05-20T17:54:29Z

 		filePath := utils.ResolveFile(dataFileName)
 		_, err = os.ReadFile(filePath)
-		test.That(t, err, test.ShouldBeError, fmt.Errorf("open %s: no such file or directory", filePath))
+		test.That(t, errors.Is(err, fs.ErrNotExist), test.ShouldBeTrue)


windows has slightly diff error string, so just check errNotExist instead of specific string

allisonschiang · 2026-05-20T17:55:08Z

 	if err != nil {
 		return errors.Wrapf(err, "failed to create %s", manifestPath)
 	}
+	defer func() { vutils.UncheckedError(manifestFile.Close()) }()


on windows, all open files need to be explicitly closed

allisonschiang · 2026-05-20T17:55:23Z

 			filepath:        "non_existent_file.md",
 			shouldContain:   []string{},
-			shouldErrorWith: "failed to read markdown file at non_existent_file.md: open non_existent_file.md: no such file or directory",
+			shouldErrorWith: "failed to read markdown file at non_existent_file.md: open non_existent_file.md:",


windows different error string

allisonschiang · 2026-05-20T17:55:49Z

 	expectedName := "viam-labs_test-module_from_reload"
 	expectedVersion := "latest-with-prerelease"
-	remoteReloadPath := ".viam/packages-local/viam-labs_test-module_from_reload-module.tar.gz"
+	expectedEntrypoint, err := filepath.Abs(manifest.Entrypoint)


forward slash issues on windows

allisonschiang · 2026-05-20T17:56:31Z

-			err = closeErr
-		}
-	}()
+	if err := f.Close(); err != nil {


need to close before removing

allisonschiang · 2026-05-20T18:06:06Z

 	ac.baseURL, _, err = utils.ParseBaseURL(ac.conf.BaseURL, false)
 	test.That(t, err, test.ShouldBeNil)

+	ac.dialOverride = func(ctx context.Context, fqdn string, rpcOpts []rpc.DialOption, logger logging.Logger) (*client.RobotClient, error) {


TestShellFileCopy/from/single_file (540.05s) hangs with

rpc/dial.go:144 trying mDNS {"address":"99823048-4cba-4b40-823e-a26f7362d4a3"}
rpc/server.go:550 mDNS setup failed; continuing with mDNS disabled {"error":"no positive MTU found"}

by adding this, we can skip the mDNS setup that will likely fail on windows and go straight to direct grpc with the actual robot data from the test

allisonschiang · 2026-05-20T18:45:56Z

-	// the manifest contains a:
-	// "setup": "./setup.sh"
-	// and a "build": "make build"
-	manifestPath := createTestManifest(t, "", nil)


default test manifest is set up for mac, need windows specifics like .bat instead of .sh

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 18, 2026

allisonschiang and others added 13 commits May 19, 2026 16:10

add cli to windows tests

00e9d60

windows test fixes: allow mDNS loopback + use errors.Is for not-exist…

779741a

… check

windows test: disable firewall + enable multicast forwarding + diag dump

8fcd488

windows test: bypass mDNS in setupWithRunningPart via dialOverride

c7c20e3

windows test: skip known-broken tests + force LF for test data

e63c51d

windows test fixes: TestResolvePartId close handle, TestMutateModuleC…

36bad1a

…onfig+TestLocalBuild+test_copy_python_template platform-aware

windows test fixes: close meta.json handle in writeManifest, relax er…

0548b63

…ror substring match Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

remove debug logging and unused mDNS firewall step

19cc0dc

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

drop test_data/.gitattributes to verify if LF override is needed

4fe1149

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

re-enable TestShellFileCopy and TestTunnelE2ECLI on Windows to surfac…

e0e8f7e

…e test infra failures Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

re-enable TestValidateOutputWritable on Windows, scope read-only subt…

34ca37c

…est skip Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

drop windows skip on read-only subtest to verify Windows enforces 0o5…

5b09200

…55 dir Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

windows test fixes: close file handles in copy_local + xacro, skip br…

40d4025

…oken tunnel test, restore gitattributes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

allisonschiang and others added 3 commits May 19, 2026 16:10

windows: skip TestShellFileCopy (RSDK-11617) and read-only subtest; r…

1fab8bc

…evert noisy copy_local close Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Update client_test.go

47e91d7

re-enable TestUpdateModelsAction on Windows after RSDK-13907 impl fix

7cd39ac

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

allisonschiang force-pushed the cli-windows-testing branch from 2577cb5 to 7cd39ac Compare May 19, 2026 20:13

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 19, 2026

make clearer

d0ebc74

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 20, 2026

allisonschiang commented May 20, 2026

View reviewed changes

simplify

6622778

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 20, 2026

allisonschiang marked this pull request as ready for review May 20, 2026 18:52

allisonschiang requested review from a team, lia-viam and njooma and removed request for a team May 20, 2026 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RSDK-13980: Enable cli windows tests#6022

RSDK-13980: Enable cli windows tests#6022
allisonschiang wants to merge 18 commits into
mainfrom
cli-windows-testing

allisonschiang commented May 18, 2026 •

edited

Loading

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026

Uh oh!

allisonschiang May 20, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

allisonschiang commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allisonschiang May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

allisonschiang commented May 18, 2026 •

edited

Loading

allisonschiang May 20, 2026 •

edited

Loading