Run go mod tidy and bump Go version to 1.25 in generated module template#5980
Open
lvhg wants to merge 2 commits into
Open
Run go mod tidy and bump Go version to 1.25 in generated module template#5980lvhg wants to merge 2 commits into
lvhg wants to merge 2 commits into
Conversation
After generating a Go module, automatically run `go mod tidy` in the new module directory to resolve dependencies. Also updates the go.mod template from go 1.23 to 1.25. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
viambot
added
the
safe to test
lvhg
requested review from
a team,
lia-viam and
njooma
and removed request for
a team
njooma
requested changes
May 1, 2026
| err = runGoImports(moduleFile) | ||
| if err != nil { | ||
| return errors.Wrap(err, "cannot generate go stubs -- unable to sort imports") | ||
| } |
Member
There was a problem hiding this comment.
Good change, but I would put it somewhere down here instead
Member
Author
There was a problem hiding this comment.
Do you think it would be okay to move the go mod tidy back to where it was previously given that the tests are failing after moving it?
Member
There was a problem hiding this comment.
Yes, but let's talk about why the tests are failing here
viambot
added
safe to test
njooma
approved these changes
May 4, 2026
Member
njooma
left a comment
njooma
left a comment
There was a problem hiding this comment.
approved, ready to merge once the checks start passing
njooma
requested changes
May 13, 2026
| err = runGoImports(moduleFile) | ||
| if err != nil { | ||
| return errors.Wrap(err, "cannot generate go stubs -- unable to sort imports") | ||
| } |
Member
There was a problem hiding this comment.
Yes, but let's talk about why the tests are failing here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After generating a Go module, automatically run
go mod tidyin the new module directory to resolve dependencies. Also updates the go.mod template from go 1.23 to 1.25.https://viam.atlassian.net/browse/APP-16176