Skip to content

Fix #1144 #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efaulhaber merged 11 commits into from
Apr 29, 2026

Fix 2adeecd

6279db3
Select commit
Loading
Failed to load commit list.
Merged

Fix #1144 #1163

Fix 2adeecd
6279db3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 29, 2026 in 1s

89.05% (-0.11%) compared to c418464

View this Pull Request on Codecov

89.05% (-0.11%) compared to c418464

Details

Codecov Report

❌ Patch coverage is 86.15385% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.05%. Comparing base (c418464) to head (6279db3).
⚠️ Report is 16 commits behind head on dev2.

Files with missing lines Patch % Lines
src/general/semidiscretization.jl 89.28% 6 Missing ⚠️
...c/schemes/structure/total_lagrangian_sph/system.jl 44.44% 5 Missing ⚠️
test/general/semidiscretization.jl 69.23% 4 Missing ⚠️
src/general/neighborhood_search.jl 81.25% 3 Missing ⚠️
.../schemes/boundary/wall_boundary/dummy_particles.jl 90.47% 2 Missing ⚠️
src/callbacks/solution_saving.jl 0.00% 1 Missing ⚠️
src/general/time_integration.jl 0.00% 1 Missing ⚠️
src/preprocessing/geometries/io.jl 0.00% 1 Missing ⚠️
.../preprocessing/particle_packing/signed_distance.jl 0.00% 1 Missing ⚠️
src/preprocessing/particle_packing/system.jl 87.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             dev2    #1163      +/-   ##
==========================================
- Coverage   89.15%   89.05%   -0.11%     
==========================================
  Files         127      128       +1     
  Lines        9980    10039      +59     
==========================================
+ Hits         8898     8940      +42     
- Misses       1082     1099      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov