Skip to content

Fix #1144#1163

Merged
efaulhaber merged 11 commits intodev2from
dev
Apr 29, 2026
Merged

Fix #1144#1163
efaulhaber merged 11 commits intodev2from
dev

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

We merged #1144 prematurely before waiting for the CI tests. There are still many problems now that cause CI failures.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Apr 29, 2026

/run-gpu-tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 86.15385% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.05%. Comparing base (c418464) to head (6279db3).

Files with missing lines Patch % Lines
src/general/semidiscretization.jl 89.28% 6 Missing ⚠️
...c/schemes/structure/total_lagrangian_sph/system.jl 44.44% 5 Missing ⚠️
test/general/semidiscretization.jl 69.23% 4 Missing ⚠️
src/general/neighborhood_search.jl 81.25% 3 Missing ⚠️
.../schemes/boundary/wall_boundary/dummy_particles.jl 90.47% 2 Missing ⚠️
src/callbacks/solution_saving.jl 0.00% 1 Missing ⚠️
src/general/time_integration.jl 0.00% 1 Missing ⚠️
src/preprocessing/geometries/io.jl 0.00% 1 Missing ⚠️
.../preprocessing/particle_packing/signed_distance.jl 0.00% 1 Missing ⚠️
src/preprocessing/particle_packing/system.jl 87.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             dev2    #1163      +/-   ##
==========================================
- Coverage   89.15%   89.05%   -0.11%     
==========================================
  Files         127      128       +1     
  Lines        9980    10039      +59     
==========================================
+ Hits         8898     8940      +42     
- Misses       1082     1099      +17     
Flag Coverage Δ
total 89.05% <86.15%> (-0.11%) ⬇️
unit 68.11% <65.12%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Apr 29, 2026

/run-gpu-tests

@efaulhaber efaulhaber marked this pull request as ready for review April 29, 2026 09:57
@efaulhaber efaulhaber requested a review from svchb April 29, 2026 09:57
@efaulhaber efaulhaber merged commit bd9e86e into dev2 Apr 29, 2026
18 of 20 checks passed
@efaulhaber efaulhaber deleted the dev branch April 29, 2026 11:39
@efaulhaber efaulhaber restored the dev branch April 29, 2026 12:18
@efaulhaber efaulhaber deleted the dev branch April 29, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants