Skip to content

Make pressure clipping in BoundaryModelDummyParticles optional #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efaulhaber merged 14 commits into from
Apr 28, 2026
Merged

Make pressure clipping in BoundaryModelDummyParticles optional #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2f11ff9
Make pressure clipping in `BoundaryModelDummyParticles` optional
efaulhaber Apr 14, 2026
45ed456
Reformat
efaulhaber Apr 17, 2026
f5a1a35
Disable pressure clipping by default
efaulhaber Apr 21, 2026
57dd9ab
Add NEWS.md entry
efaulhaber Apr 21, 2026
f96828b
Make free surface examples use boundary pressure clipping
efaulhaber Apr 21, 2026
670e1a3
Fix tests
efaulhaber Apr 22, 2026
d39b606
Fix smoothing length in example tests
efaulhaber Apr 22, 2026
19b89a1
Merge branch 'dev' into boundary-pressure-clipping
efaulhaber Apr 22, 2026
27d9b7a
Fix
efaulhaber Apr 23, 2026
d4db1cf
Fix
efaulhaber Apr 23, 2026
11337f3
Update docstring
efaulhaber Apr 23, 2026
1c1cbd9
Update docstrings
efaulhaber Apr 23, 2026
15cf8c3
Unify example tests
efaulhaber Apr 27, 2026
a6c8cb0
Reformat
efaulhaber Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,10 @@ used in the Julia ecosystem. Notable changes will be documented in this file for
### API Changes

- `DensityDiffusionAntuono` now only takes only one kwarg `delta` (#1142).
- Clipping of negative pressure values in the `DummyParticleBoundaryModel` is now disabled
by default and can be enabled with the keyword argument `clip_negative_pressure=true` (#1143).
- Return type of `vtk2trixi` changed to `NamedTuple` including an optional
`:initial_condition` field if `create_initial_condition=true` is passed. (#959)

## Version 0.4.4

### API Changes

`:initial_condition` field if `create_initial_condition=true` is passed (#959).
- Custom quantities called in the `PostprocessCallback` are now passed CPU arrays when
the simulation is run on a GPU (#1065).

Expand Down
5 changes: 4 additions & 1 deletion examples/fluid/dam_break_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,16 @@ boundary_density_calculator = AdamiPressureExtrapolation()
viscosity_wall = nothing
# For a no-slip boundary condition, define a wall viscosity:
# viscosity_wall = viscosity_fluid

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
smoothing_kernel, smoothing_length,
correction=nothing,
reference_particle_spacing=0,
viscosity=viscosity_wall)
viscosity=viscosity_wall,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model,
adhesion_coefficient=0.0)
Expand Down
5 changes: 4 additions & 1 deletion examples/fluid/dam_break_3d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,13 @@ fluid_system = WeaklyCompressibleSPHSystem(tank.fluid, fluid_density_calculator,
# ==========================================================================================
# ==== Boundary
boundary_density_calculator = AdamiPressureExtrapolation()

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
smoothing_kernel, smoothing_length)
smoothing_kernel, smoothing_length,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model)

Expand Down
5 changes: 4 additions & 1 deletion examples/fluid/falling_water_column_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,13 @@ fluid_system = WeaklyCompressibleSPHSystem(tank.fluid, fluid_density_calculator,
# ==========================================================================================
# ==== Boundary
boundary_density_calculator = AdamiPressureExtrapolation()

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
smoothing_kernel, smoothing_length)
smoothing_kernel, smoothing_length,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model)

Expand Down
5 changes: 4 additions & 1 deletion examples/fluid/falling_water_spheres_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,15 @@ sphere = WeaklyCompressibleSPHSystem(sphere2, fluid_density_calculator,
# ==== Boundary
boundary_density_calculator = AdamiPressureExtrapolation()
wall_viscosity = nu

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
fluid_smoothing_kernel, fluid_smoothing_length,
viscosity=ViscosityAdami(nu=wall_viscosity),
reference_particle_spacing=fluid_particle_spacing)
reference_particle_spacing=fluid_particle_spacing,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model,
adhesion_coefficient=1.0)
Expand Down
11 changes: 8 additions & 3 deletions examples/fsi/dam_break_gate_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,19 @@ fluid_system = WeaklyCompressibleSPHSystem(tank.fluid, fluid_density_calculator,
# ==========================================================================================
# ==== Boundary
boundary_density_calculator = AdamiPressureExtrapolation()

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model_tank = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
smoothing_kernel, smoothing_length)
smoothing_kernel, smoothing_length,
clip_negative_pressure=true)

boundary_model_gate = BoundaryModelDummyParticles(gate.density, gate.mass,
state_equation=state_equation,
boundary_density_calculator,
smoothing_kernel, smoothing_length)
smoothing_kernel, smoothing_length,
clip_negative_pressure=true)

boundary_system_tank = WallBoundarySystem(tank.boundary, boundary_model_tank)
boundary_system_gate = WallBoundarySystem(gate, boundary_model_gate,
Expand All @@ -145,7 +149,8 @@ boundary_model_structure = BoundaryModelDummyParticles(hydrodynamic_densites,
hydrodynamic_masses,
state_equation=state_equation,
AdamiPressureExtrapolation(),
smoothing_kernel, smoothing_length)
smoothing_kernel, smoothing_length,
clip_negative_pressure=true)

structure_system = TotalLagrangianSPHSystem(structure,
structure_smoothing_kernel,
Expand Down
8 changes: 6 additions & 2 deletions examples/fsi/dam_break_plate_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,13 @@ fluid_system = WeaklyCompressibleSPHSystem(tank.fluid, fluid_density_calculator,
# ==========================================================================================
# ==== Boundary
boundary_density_calculator = AdamiPressureExtrapolation()

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
smoothing_kernel, smoothing_length)
smoothing_kernel, smoothing_length,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model)

Expand Down Expand Up @@ -121,7 +124,8 @@ boundary_model_structure = BoundaryModelMonaghanKajtar(k_structure, spacing_rati
# hydrodynamic_masses,
# state_equation=state_equation,
# boundary_density_calculator,
# smoothing_kernel, smoothing_length)
# smoothing_kernel, smoothing_length,
# clip_negative_pressure=true)

structure_system = TotalLagrangianSPHSystem(structure,
structure_smoothing_kernel,
Expand Down
5 changes: 4 additions & 1 deletion examples/fsi/falling_rigid_spheres_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,13 @@ fluid_system = WeaklyCompressibleSPHSystem(tank.fluid, fluid_density_calculator,
# ==========================================================================================
# ==== Boundary
boundary_density_calculator = AdamiPressureExtrapolation()

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
fluid_smoothing_kernel, fluid_smoothing_length)
fluid_smoothing_kernel, fluid_smoothing_length,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model)

Expand Down
5 changes: 4 additions & 1 deletion examples/fsi/falling_rotating_rigid_squares_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,13 @@ fluid_system = WeaklyCompressibleSPHSystem(tank.fluid, fluid_density_calculator,
# ==========================================================================================
# ==== Boundary
boundary_density_calculator = AdamiPressureExtrapolation()

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
fluid_smoothing_kernel, fluid_smoothing_length)
fluid_smoothing_kernel, fluid_smoothing_length,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model)

Expand Down
11 changes: 8 additions & 3 deletions examples/fsi/falling_spheres_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,13 @@ fluid_system = WeaklyCompressibleSPHSystem(tank.fluid, fluid_density_calculator,
# ==========================================================================================
# ==== Boundary
boundary_density_calculator = BernoulliPressureExtrapolation()

# Clip negative boundary pressure values to avoid sticking artifacts at the boundary.
boundary_model = BoundaryModelDummyParticles(tank.boundary.density, tank.boundary.mass,
state_equation=state_equation,
boundary_density_calculator,
fluid_smoothing_kernel, fluid_smoothing_length)
fluid_smoothing_kernel, fluid_smoothing_length,
clip_negative_pressure=true)

boundary_system = WallBoundarySystem(tank.boundary, boundary_model)

Expand All @@ -93,7 +96,8 @@ structure_boundary_model_1 = BoundaryModelDummyParticles(hydrodynamic_densites_1
state_equation=state_equation,
boundary_density_calculator,
fluid_smoothing_kernel,
fluid_smoothing_length)
fluid_smoothing_length,
clip_negative_pressure=true)

hydrodynamic_densites_2 = fluid_density * ones(size(sphere2.density))
hydrodynamic_masses_2 = hydrodynamic_densites_2 *
Expand All @@ -104,7 +108,8 @@ structure_boundary_model_2 = BoundaryModelDummyParticles(hydrodynamic_densites_2
state_equation=state_equation,
boundary_density_calculator,
fluid_smoothing_kernel,
fluid_smoothing_length)
fluid_smoothing_length,
clip_negative_pressure=true)

structure_system_1 = TotalLagrangianSPHSystem(sphere1,
structure_smoothing_kernel,
Expand Down
Loading
Loading