Make pressure clipping in BoundaryModelDummyParticles optional

[efaulhaber]

Pressure clipping is not a correct formulation, it is just a workaround to avoid sticking artifacts.
Away from free surfaces it leads to artificially increased boundary pressures that cause larger gaps between fluid and boundary in areas of low pressure, against which the particle shifting technique is fighting.

This PR adds an option to disable clipping, which should be enabled for closed systems.

[codecov]

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.03%. Comparing base (b0144b4) to head (a6c8cb0).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
.../schemes/boundary/wall_boundary/dummy_particles.jl	86.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1143      +/-   ##
==========================================
- Coverage   89.03%   89.03%   -0.01%     
==========================================
  Files         128      128              
  Lines       10032    10040       +8     
==========================================
+ Hits         8932     8939       +7     
- Misses       1100     1101       +1     

Flag	Coverage Δ
total	89.03% <86.66%> (-0.01%)	⬇️
unit	68.10% <86.66%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR makes negative pressure clipping in BoundaryModelDummyParticles configurable so it can be disabled for closed-system simulations where clipping would be physically incorrect and can introduce artifacts.

Changes:

• Added a clip_negative_pressure keyword (default true) to BoundaryModelDummyParticles and threaded it through the model type for compile-time branching.
• Updated boundary pressure computation to conditionally clip negative pressures (both for state-equation-based pressure and Adami extrapolation).
• Added tests covering clipping on/off behavior and ensuring the setting survives Adapt.adapt.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/schemes/boundary/wall_boundary/dummy_particles.jl	Adds optional negative-pressure clipping to BoundaryModelDummyParticles with a static (type-parameter) flag used in pressure update paths.
test/schemes/boundary/dummy_particles/dummy_particles.jl	Adds unit tests validating clipping behavior for multiple density calculators and through Adapt.adapt.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[svchb]

What is supposed to happen when clipping in the state equation is activated and deactivated here?

[efaulhaber]

When clipping in the state equation is activated, then pressure is clipped everywhere and it cannot become negative anyway, except perhaps with Adami when the boundary is accelerated away from the fluid.

[svchb]

But shouldn't this be an error than or warning?

[efaulhaber]

But shouldn't this be an error than or warning?

Why? Everything is working as expected.

[svchb]

Because the inconsistency might be confusing.

[efaulhaber]

I don't see an inconsistency. Enable pressure clipping for the boundary model to clip boundary pressure. Enable pressure clipping of the state equation to enable global pressure clipping.

[svchb]

Ok than just adjust the docstring also for state equation pressure clipping.

[svchb]

• Add a similar note to state equation
• add a test for the mixed stateequation/boundary clipping

[efaulhaber]

/run-gpu-tests

[efaulhaber]

/run-gpu-tests