[ros_bridge] Remove unused *.conf.in files to avoid confusion.#301
Open
130s wants to merge 2 commits intotork-a:indigo-develfrom
Open
[ros_bridge] Remove unused *.conf.in files to avoid confusion.#301130s wants to merge 2 commits intotork-a:indigo-develfrom
130s wants to merge 2 commits intotork-a:indigo-develfrom
Conversation
130s
force-pushed
the
rm/unused_conf_in_files
branch
3 times, most recently
from
8db154a to
db8a4d3
Compare
[CMakeLists.txt](https://github.com/tork-a/rtmros_nextage/blob/7ff2bfd17471225e43bfeef0cc35b0b87f19058b/nextage_ros_bridge/CMakeLists.txt#L50_L55) uses *conf.in files from the upstream `hironx_ros_bridge` package. However there are at least a few changes to the files to some conf.in files: tork-a#226 tork-a#279 Thus I'm not sure if this change is correct.
130s
force-pushed
the
rm/unused_conf_in_files
branch
from
db8a4d3 to
acb1d6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt uses *conf.in files from the upstream
hironx_ros_bridgepackage. However there are at least a few changes to some conf.in files:#226
#279
Thus I'm not sure if this change is correct.