Skip to content

chore(workflow): add SDK parity dispatch workflow #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salihdev0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(workflow): add SDK parity dispatch workflow #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/sdk-parity-dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: SDK Parity Dispatch

on:
push:
paths:
Comment on lines +1 to +5
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow doesn’t declare explicit permissions. When invoking external reusable workflows (especially alongside secret usage), it’s safer to set least-privilege permissions for GITHUB_TOKEN (for example contents: read and only additional scopes if required).

Copilot uses AI. Check for mistakes.
- "src/**"
- "package.json"
pull_request:
paths:
- "src/**"
- "package.json"
workflow_dispatch:

jobs:
parity-dispatch:
uses: tapsilat/tapsilat-sdk-parity/.github/workflows/reusable-sdk-parity-dispatch.yml@main
Comment on lines +15 to +16
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable workflow reference is pinned to @main, which is mutable. Since this job also inherits secrets, upstream changes on main could unexpectedly change behavior or exfiltrate secrets. Pin the reusable workflow to an immutable ref (a commit SHA or a version tag) and update it intentionally when needed.

Copilot uses AI. Check for mistakes.
secrets: inherit
Comment on lines +16 to +17
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secrets: inherit passes all repository/environment secrets to the called workflow. Given this calls a reusable workflow from a different repository, this is a broad secret exposure surface. Prefer explicitly passing only the specific secrets the reusable workflow needs (or avoid secrets entirely if possible).

Copilot uses AI. Check for mistakes.