Skip to content

chore(workflow): add SDK parity dispatch workflow#14

Open
salihdev0 wants to merge 1 commit into
mainfrom
feat/sdk-parity
Open

chore(workflow): add SDK parity dispatch workflow#14
salihdev0 wants to merge 1 commit into
mainfrom
feat/sdk-parity

Conversation

@salihdev0
Copy link
Copy Markdown
Contributor

  • Introduced a new GitHub Actions workflow for SDK parity dispatch.
  • Triggers on push and pull request events for changes in the src directory and package.json.
  • Utilizes a reusable workflow from the tapsilat/tapsilat-sdk-parity repository.
  • Inherits secrets for secure access during execution.

- Introduced a new GitHub Actions workflow for SDK parity dispatch.
- Triggers on push and pull request events for changes in the `src` directory and `package.json`.
- Utilizes a reusable workflow from the tapsilat/tapsilat-sdk-parity repository.
- Inherits secrets for secure access during execution.
Copilot AI review requested due to automatic review settings April 8, 2026 20:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow that dispatches an SDK parity check by invoking a reusable workflow from tapsilat/tapsilat-sdk-parity, scoped to changes in src/** and package.json.

Changes:

  • Introduced SDK Parity Dispatch workflow triggered on push, pull_request, and manual workflow_dispatch.
  • Configured path filters to run only when src/** or package.json changes.
  • Delegated execution to an external reusable workflow and inherited caller secrets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +15 to +16
parity-dispatch:
uses: tapsilat/tapsilat-sdk-parity/.github/workflows/reusable-sdk-parity-dispatch.yml@main
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable workflow reference is pinned to @main, which is mutable. Since this job also inherits secrets, upstream changes on main could unexpectedly change behavior or exfiltrate secrets. Pin the reusable workflow to an immutable ref (a commit SHA or a version tag) and update it intentionally when needed.

Copilot uses AI. Check for mistakes.
Comment on lines +16 to +17
uses: tapsilat/tapsilat-sdk-parity/.github/workflows/reusable-sdk-parity-dispatch.yml@main
secrets: inherit
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secrets: inherit passes all repository/environment secrets to the called workflow. Given this calls a reusable workflow from a different repository, this is a broad secret exposure surface. Prefer explicitly passing only the specific secrets the reusable workflow needs (or avoid secrets entirely if possible).

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +5
name: SDK Parity Dispatch

on:
push:
paths:
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow doesn’t declare explicit permissions. When invoking external reusable workflows (especially alongside secret usage), it’s safer to set least-privilege permissions for GITHUB_TOKEN (for example contents: read and only additional scopes if required).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants