fix: report diagnostics in tsconfig.json#3005
Merged
jasonlyu123 merged 4 commits intosveltejs:masterfrom Apr 30, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 4ed42b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Copilot <copilot@github.com>
warning for now to avoid breaking change Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svelte-check side of #3004
One problem is that svelte-check doesn't report these diagnostics before. Does this count as a breaking change? We intended to report these in svelte-check v4, but I don't realise there are other APIs for config file diagnostics. Some people might have options deprecated in TypeScript 5.5, but were never reported in svelte-check.
In incremental/tsgo, we have to report these errors because TypeScript won't proceed to type-check. But in regular svelte-check, the type-check is still reported. If we consider this as a breaking change, should we report these as warnings for now and change them to errors in v5?