fix(storage): make signedURL an optional string#1461
Merged
Conversation
grdsdev
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #1455, by making
signedUrlanOptional[str].What is the current behavior?
When a path that does not exist is passed to
create_signed_urls, it will return an item witherrorset andsignedURL: null, and when we try to validate the payload, a validation error is thrown.What is the new behavior?
No errors are thrown, and the item will have
signedUrl=None.Additional context
This error originates from the JS type annotations being wrong. The corresponding fix for it is contained here