fix(storage3): Handle None for non-existent signed URLs#1456
Closed
NafeesMadni wants to merge 1 commit intosupabase:mainfrom
Closed
fix(storage3): Handle None for non-existent signed URLs#1456NafeesMadni wants to merge 1 commit intosupabase:mainfrom
NafeesMadni wants to merge 1 commit intosupabase:mainfrom
Conversation
Contributor
|
This PR also needs to fix the tests and some annotations in order to keep I'll close it in favor of #1461, where I've applied a very similar fix to it, while keeping the types correct. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The
create_signed_urlsfunction raises apydantic_core._pydantic_core.ValidationErrorwhen attempting to generate signed URLs for files that do not exist in a Supabase storage bucket. This occurs because the Supabase API returns null for thesignedURLfield for non-existent files, but the SDK'sSignedUrlsJsonItemPydantic model expects a string.Relevant issue: #1455
What is the new behavior?
This PR updates the
SignedUrlsJsonItemPydantic model to correctly mark thesignedURLfield asOptional[str]. Additionally, thecreate_signed_urlsmethods in both the asynchronous and synchronous file API implementations have been modified to gracefully handleNonevalues forsignedURLfrom the API response.Now, if a requested file does not exist, the corresponding entry in the
CreateSignedUrlResponselist will correctly reflectNoneforsignedURLandsignedUrl, without causing a validation error.Additional context
This fix enhances the robustness of the storage client, preventing crashes when querying for signed URLs of potentially non-existent files. Users can now safely request signed URLs for a list of files, even if some are missing, without the application crashing due to Pydantic validation failures.