Skip to content

Fix the convergence check being skipped when verbose=True #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roytsmart merged 1 commit into from
Jul 30, 2026
Merged

Fix the convergence check being skipped when verbose=True #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ctis/inverters/_iterative/_mart/_mart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def __call__(
if verbose: # pragma: nocover
print(f"merit: {merit}")

elif (merit_old - merit) < self.threshold_convergence:
if (merit_old - merit) < self.threshold_convergence:
message = f"Achieved merit less than {self.threshold_convergence}."
success = True
num_iteration = i + 1
Expand Down
16 changes: 16 additions & 0 deletions ctis/inverters/_iterative/_mart/_mart_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,19 @@ def test__call__(
assert isinstance(fig, plt.Figure)
for ax in axs:
assert isinstance(ax, plt.Axes)


def test__call__verbose_convergence():
"""
Verbose output must not disable the convergence check.
"""
a = ctis.inverters.MartInverter(
instrument=instrument,
num_iteration=50,
threshold_convergence=1e-2,
)

result = a(images, verbose=True)

assert result.success
assert result.num_iteration < a.num_iteration
Loading