Fix the convergence check being skipped when verbose=True - #21
Open
jacobdparker wants to merge 1 commit into
Open
Fix the convergence check being skipped when verbose=True#21jacobdparker wants to merge 1 commit into
jacobdparker wants to merge 1 commit into
Conversation
The convergence test in MartInverter.__call__ was an elif chained behind the verbose print statement, so any run with verbose output could never stop at the convergence threshold and always ran to num_iteration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HuYXL1BkWsWGAxYnpD8Kqz
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 697 702 +5
=========================================
+ Hits 697 702 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convergence test in
MartInverter.__call__was anelifchained behind theverboseprint statement:so any run with verbose output could never stop at the convergence threshold and always ran to
num_iteration(with the max-iterations warning). Found while running MART inversions of the ESIS-I flight data, where verbose runs always burned the full iteration budget.This splits the check into an independent
if, and adds a regression test that inverts withverbose=Trueand asserts early convergence — the test fails on the previous code.🤖 Generated with Claude Code
https://claude.ai/code/session_01HuYXL1BkWsWGAxYnpD8Kqz