Skip to content

SPIKE: Protocol 28 (CAP-0084) #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sisuresh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

SPIKE: Protocol 28 (CAP-0084) #307

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b56181
Add CAP-0084 muxed contract address XDR
sisuresh Jun 26, 2026
787382e
Keep p28 SPIKE XDR base identical to frozen p27 host (drop unrelated …
sisuresh Jul 1, 2026
a29d56a
Revert out-of-scope rentFeeCharged comment change
sisuresh Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Stellar-contract.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ enum SCAddressType
SC_ADDRESS_TYPE_MUXED_ACCOUNT = 2,
SC_ADDRESS_TYPE_CLAIMABLE_BALANCE = 3,
SC_ADDRESS_TYPE_LIQUIDITY_POOL = 4
#ifdef CAP_0084_MUXED_CONTRACT
,
SC_ADDRESS_TYPE_MUXED_CONTRACT = 5
#endif
};

struct MuxedEd25519Account
Expand All @@ -191,6 +195,14 @@ struct MuxedEd25519Account
uint256 ed25519;
};

#ifdef CAP_0084_MUXED_CONTRACT

@dmkozh dmkozh Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the additional suffix necessary? I'm not sure if it adds much value, given that we shouldn't have more than a single guard per CAP.

@sisuresh sisuresh Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was based on some feedback in the FSR channel. It just adds a little clarity so you don't need to remember what the CAP number does.

@dmkozh dmkozh Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I don't have too strong opinion, we can try this as well.

struct MuxedContract
{
uint64 id;
ContractID contractId;
};
#endif

union SCAddress switch (SCAddressType type)
{
case SC_ADDRESS_TYPE_ACCOUNT:
Expand All @@ -203,6 +215,10 @@ case SC_ADDRESS_TYPE_CLAIMABLE_BALANCE:
ClaimableBalanceID claimableBalanceId;
case SC_ADDRESS_TYPE_LIQUIDITY_POOL:
PoolID liquidityPoolId;
#ifdef CAP_0084_MUXED_CONTRACT
case SC_ADDRESS_TYPE_MUXED_CONTRACT:
MuxedContract muxedContract;
#endif
};

%struct SCVal;
Expand Down
Loading