Update stellar-strkey to 0.0.18#99
Open
leighmcculloch wants to merge 3 commits into
Open
Conversation
0.0.18 includes the strkey CLI fix (accept owned variant keys for Decoded<Strkey>). It is not yet on crates.io, so temporarily patch stellar-strkey to the release/v0.0.18 branch to validate ahead of the release. Remove the patch once 0.0.18 is published.
leighmcculloch
changed the title
0.0.18 is now published to crates.io, so drop the temporary [patch.crates-io] that pointed stellar-strkey at the release/v0.0.18 git branch (and the matching stellar-cli deny.toml allow-git entry). The dependency now resolves from crates.io.
There was a problem hiding this comment.
Pull request overview
This PR updates the crate’s direct stellar-strkey dependency to 0.0.18 to align with the latest stellar-strkey release line (Protocol 28 coordination), and refreshes the lockfile to match the new resolved dependency graph.
Changes:
- Bump direct dependency
stellar-strkeyfrom0.0.16to0.0.18inCargo.toml. - Update
Cargo.lockto reflect the newstellar-strkeyversion and its updated transitive dependencies (notablyheapless 0.9.x,zeroize, andcrate-git-revision 0.0.9), while keeping transitivestellar-strkey 0.0.13(viastellar-xdr 27.0.0) unchanged.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Bumps the direct stellar-strkey dependency to 0.0.18. |
| Cargo.lock | Updates resolved dependencies for the stellar-strkey 0.0.18 bump (adds/updates transitive crates accordingly). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the direct
stellar-strkeydependency from 0.0.16 to 0.0.18 inCargo.toml, and updateCargo.lockaccordingly. The transitivestellar-strkey0.0.13 (pulled in via publishedstellar-xdr27.0.0) is unchanged.Why
This adopts the latest
stellar-strkeyrelease, which targets the stellar-strkey release line for protocol 28. Keeping the direct dependency current ensures the RPC client builds against the up-to-date strkey API.cargo checkpasses with no source changes required.This supersedes the earlier 0.0.17 bump: 0.0.17 contained a CLI bug (
Decoded<Strkey>rejected owned JSON keys, breakingstrkey encode), fixed in 0.0.18 by stellar/rs-stellar-strkey#125.Known limitations
N/A
Protocol 28 coordination
This is one of a coordinated set of PRs bumping
stellar-strkeyto 0.0.18 across the Protocol 28 component stack. It is preferred that all Protocol 28 releases of these components depend on the same version ofstellar-strkey:stellar-strkey0.0.18 raises the minimum supported Rust version to 1.87 and updates/adds transitive dependencies (heapless0.9,zeroize), so MSRV and supply-chain policy (cargo-deny / cackle) updates may be required in some repositories before CI is green.