Update stellar-strkey to 0.0.18#1694
Open
leighmcculloch wants to merge 7 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XiSfu2MM5xbdGjxj7oXys8
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XiSfu2MM5xbdGjxj7oXys8
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XiSfu2MM5xbdGjxj7oXys8
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XiSfu2MM5xbdGjxj7oXys8
0.0.18 includes the strkey CLI fix (accept owned variant keys for Decoded<Strkey>). It is not yet on crates.io, so temporarily patch stellar-strkey to the release/v0.0.18 branch to validate ahead of the release. Remove the patch once 0.0.18 is published.
leighmcculloch
commented
Jun 18, 2026
leighmcculloch
left a comment
Member
Author
There was a problem hiding this comment.
Few comments inline for why changes are required.
| } | ||
| }; | ||
| Ok(strkey.to_string()) | ||
| Ok(strkey.to_string().as_str().to_string()) |
Member
Author
There was a problem hiding this comment.
The string returned from strkey's is now a heapless string, so this seemingly odd dance is converting that heapless string into an alloc String.
0.0.18 is now published to crates.io, so drop the temporary [patch.crates-io] that pointed stellar-strkey at the release/v0.0.18 git branch (and the matching stellar-cli deny.toml allow-git entry). The dependency now resolves from crates.io.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace to use stellar-strkey v0.0.18 (needed for Protocol 28) and raises the workspace MSRV to Rust 1.87, adapting soroban-env-host call sites to the updated stellar-strkey string-returning API.
Changes:
- Bump
stellar-strkeyinsoroban-env-hostfrom0.0.13to0.0.18and adjust strkey encoding conversions inhost/conversion.rs. - Raise
rust-versionto1.87.0in the workspace and affected crates. - Update supply-chain policy configuration (
deny.toml,cackle.toml) andCargo.lockto account for new/duplicate dependencies.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Raises workspace MSRV to Rust 1.87.0. |
soroban-env-host/Cargo.toml |
Bumps direct stellar-strkey dependency to 0.0.18 and sets crate MSRV to 1.87.0. |
soroban-fuzz-targets/Cargo.toml |
Raises crate MSRV to 1.87.0. |
soroban-env-host/src/host/conversion.rs |
Updates strkey encoding call sites to convert heapless::String to std::string::String. |
soroban-env-host/src/crypto/poseidon/poseidon2.rs |
Replaces a divisibility check implementation (currently introduces a compile issue). |
soroban-env-host/src/crypto/poseidon/poseidon2_params.rs |
Replaces an evenness check implementation (currently introduces a compile issue). |
soroban-env-host/src/crypto/poseidon/poseidon_params.rs |
Replaces an evenness check implementation (currently introduces a compile issue). |
deny.toml |
Skips the expected transitional duplicate stellar-strkey 0.0.13 in cargo-deny duplicates. |
cackle.toml |
Updates cackle allowlists for newly introduced transitive crates. |
Cargo.lock |
Lockfile refresh reflecting stellar-strkey 0.0.18 and new transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmkozh
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the direct
stellar-strkeydependency insoroban-env-hostfrom 0.0.13 to 0.0.18, and adapts the two strkey-encoding call sites inhost/conversion.rsto the new API. In 0.0.17+ the crate isno_stdby default andStrkey::to_string()now returns a fixed-capacityheapless::Stringrather thanstd::string::String, so those sites now convert via.as_str().to_string(). The lockfile re-resolves to contain both 0.0.18 (forsoroban-env-host) and 0.0.13 (transitively via the publishedstellar-xdr27.0.0, which still pins 0.0.13); the 0.0.13 entry is expected and left in place, anddeny.tomlskips the duplicate.Why
This moves
soroban-env-hostonto the stellar-strkey release line targeted for protocol 28.This supersedes the earlier 0.0.17 bump: 0.0.17 contained a CLI bug (
Decoded<Strkey>rejected owned JSON keys, breakingstrkey encode), fixed in 0.0.18 by stellar/rs-stellar-strkey#125.Known limitations
N/A
Protocol 28 coordination
This is one of a coordinated set of PRs bumping
stellar-strkeyto 0.0.18 across the Protocol 28 component stack. It is preferred that all Protocol 28 releases of these components depend on the same version ofstellar-strkey:stellar-strkey0.0.18 raises the minimum supported Rust version to 1.87 and updates/adds transitive dependencies (heapless0.9,zeroize), so MSRV and supply-chain policy (cargo-deny / cackle) updates may be required in some repositories before CI is green.