Skip to content

Test that every (main) trace column is used in the constraints. - #670

Merged
liorgold2 merged 1 commit into
mainfrom
spr/main/210c8940
Jul 26, 2026
Merged

liorgold2 merged 1 commit into
mainfrom
spr/main/210c8940

Conversation

@liorgold2

@liorgold2 liorgold2 commented Jul 21, 2026 •

Copy link
Copy Markdown
Collaborator

Stack:


⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@cursor

cursor Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to debug metadata and test-time circuit analysis assertions; verifier proof logic is unchanged aside from storing OODS trace vars for analysis.

Overview
Adds a circuit analysis check that every main-trace column sampled at the OODS point is wired into the composition polynomial (via the composition_eval add/mul dependency cone).

To support that, DebugInfo gains a lists map for named Vec<Var>, and verify records proof.trace_at_oods under "trace_at_oods" before the existing logup-summand validation runs.

Reviewed by Cursor Bugbot for commit ec8cf70. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@liorgold2
liorgold2 requested a review from anatgstarkware July 21, 2026 13:19

@anatgstarkware anatgstarkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@anatgstarkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on liorgold2).

@liorgold2
liorgold2 force-pushed the spr/main/210c8940 branch from 300b724 to ec8cf70 Compare July 26, 2026 06:48
@liorgold2
liorgold2 changed the base branch from spr/main/8e71b6b9 to main July 26, 2026 06:48

@liorgold2 liorgold2 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liorgold2 reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on liorgold2).

@liorgold2
liorgold2 merged commit 141a93f into main Jul 26, 2026
12 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants