Skip to content

Refactor Context::debug_info to a struct. - #669

Merged
liorgold2 merged 1 commit into
mainfrom
spr/main/8e71b6b9
Jul 26, 2026
Merged

liorgold2 merged 1 commit into
mainfrom
spr/main/8e71b6b9

Conversation

@liorgold2

@liorgold2 liorgold2 commented Jul 21, 2026 •

Copy link
Copy Markdown
Collaborator

Stack:


⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@cursor

cursor Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Debug-only metadata refactor with no production verification logic changes.

Overview
Replaces Context::debug_info from a bare HashMap<String, Var> with a DebugInfo wrapper that holds named test variables in debug_info.vars.

Call sites in stark_verifier::verify (logup sum, interaction challenges, composition coeff/eval) now insert through .debug_info.vars. cairo_verifier::circuit_analysis::analyze takes &DebugInfo and reads the same keys via debug_info.vars. No verifier or analysis behavior changes—only the shape of debug metadata for future extension (stack follow-ups).

Reviewed by Cursor Bugbot for commit dc7775c. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@liorgold2
liorgold2 requested a review from anatgstarkware July 21, 2026 13:19

@anatgstarkware anatgstarkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@anatgstarkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on liorgold2).

@liorgold2
liorgold2 force-pushed the spr/main/8e71b6b9 branch from c76c83f to dc7775c Compare July 23, 2026 11:31
@liorgold2
liorgold2 enabled auto-merge (squash) July 23, 2026 11:31

@liorgold2 liorgold2 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liorgold2 reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on liorgold2).

@liorgold2
liorgold2 merged commit 11319d2 into main Jul 26, 2026
12 of 21 checks passed

Copy link
Copy Markdown

Security scan complete — no issues detected.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants