Refactor CMake with JRL CMake Modules v2 - #612
Open
ahoarau wants to merge 95 commits into
Open
Conversation
ahoarau
marked this pull request as draft
December 11, 2025 16:38
ManifoldFR
marked this pull request as ready for review
December 17, 2025 15:02
ManifoldFR
marked this pull request as draft
December 17, 2025 15:02
ahoarau
force-pushed
the
jrl-next
branch
2 times, most recently
from
December 22, 2025 13:28
e114b10 to
7d7943a
Compare
jorisv
requested changes
Dec 30, 2025
jorisv
left a comment
jorisv
left a comment
Contributor
There was a problem hiding this comment.
Nice work, the CMakeLists are way clearer.
ahoarau
force-pushed
the
jrl-next
branch
2 times, most recently
from
February 11, 2026 09:46
b8cf5d4 to
c8bb47e
Compare
ahoarau
force-pushed
the
jrl-next
branch
2 times, most recently
from
March 24, 2026 09:03
82e628b to
d588970
Compare
ahoarau
force-pushed
the
jrl-next
branch
3 times, most recently
from
April 15, 2026 14:31
567f237 to
41bfb1e
Compare
jorisv
requested changes
May 29, 2026
jorisv
reviewed
Jun 2, 2026
Closed
ahoarau
force-pushed
the
jrl-next
branch
2 times, most recently
from
June 26, 2026 15:42
7008d9a to
41adff3
Compare
original is from templates/deprecated.hpp.in
ahoarau
marked this pull request as ready for review
August 4, 2026 09:01
jorisv
requested changes
Aug 6, 2026
jorisv
reviewed
Aug 6, 2026
jorisv
previously approved these changes
Aug 6, 2026
We now require doxygen+graphviz if set to ON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a full rewrite of the CMake files with the JRL CMake Modules v2.
c++17minimum required