Repository navigation
SNOW-4537772, SNOW-4537761: Use positional UDTF columns in DataFrameReader.jdbc - #4522
Open
sfc-gh-yuwang wants to merge 3 commits into
Open
sfc-gh-yuwang wants to merge 3 commits into
sfc-gh-yuwang wants to merge 3 commits into
Conversation
…eader.jdbc Source column names were emitted raw as Java fields, UDTF output columns and in the table-mode SELECT list, so spaces, quotes, unicode, keywords or case-only duplicates failed to compile, and long names made wide tables exceed the UDTF signature length limit. The UDTF now returns C0..CN and the real names are restored by alias; table mode reads SELECT * by position. Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
sfc-gh-yuwang
requested review from
sfc-gh-aling,
sfc-gh-bkogan and
sfc-gh-mayliu
and removed request for
a team
November 18, 2026 18:41
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## yuwang/SNOW-4537770-jdbc-init-in-inference #4522 +/- ##
=============================================================================
Coverage ? 95.56%
=============================================================================
Files ? 179
Lines ? 47067
Branches ? 8148
=============================================================================
Hits ? 44979
Misses ? 1301
Partials ? 787 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 of 11 tasks
Report the 500-column limit and projection workaround before read UDTF registration, and cover its boundary. Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
Treat JDBC metadata as literal text instead of SQL quoting syntax so boundary quotes are not stripped or rejected. Cover quoted names in query and table modes. Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4521 (part of the
read.jdbc()GA epic SNOW-4522813). Review the ticket implementation and its additive audit commits.Summary
Source column names were emitted raw as Java fields, UDTF output columns and in
the table-mode SELECT list, so spaces, quotes, unicode, keywords or case-only
duplicates failed to compile, and long names made wide tables exceed the UDTF
signature length limit. The UDTF now returns C0..CN and the real names are
restored by alias; table mode reads SELECT * by position.
Test plan
tests/unit/test_data_source.py(new regression tests fail without the fix)tests/integ/datasource/test_jdbc.pyagainst live Oracle, PostgreSQL, MySQL and SQL Server (42 passed on the stack tip)Resumed audit (2026-11-19)
Each PR was tested in an isolated worktree at its own remote head plus the additive changes noted above. No restack, sibling integration, merge, or Jira writes were performed; this is not validation of a combined stack.
Generated with Snowflake CoCo