Skip to content

SNOW-4537772, SNOW-4537761: Use positional UDTF columns in DataFrameReader.jdbc - #4522

Open
sfc-gh-yuwang wants to merge 3 commits into
yuwang/SNOW-4537770-jdbc-init-in-inferencefrom
yuwang/SNOW-4537772-jdbc-column-names
Open

sfc-gh-yuwang wants to merge 3 commits into
yuwang/SNOW-4537770-jdbc-init-in-inferencefrom
yuwang/SNOW-4537772-jdbc-column-names

Conversation

@sfc-gh-yuwang

@sfc-gh-yuwang sfc-gh-yuwang commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #4521 (part of the read.jdbc() GA epic SNOW-4522813). Review the ticket implementation and its additive audit commits.

Summary

Source column names were emitted raw as Java fields, UDTF output columns and in
the table-mode SELECT list, so spaces, quotes, unicode, keywords or case-only
duplicates failed to compile, and long names made wide tables exceed the UDTF
signature length limit. The UDTF now returns C0..CN and the real names are
restored by alias; table mode reads SELECT * by position.

Test plan

  • tests/unit/test_data_source.py (new regression tests fail without the fix)
  • tests/integ/datasource/test_jdbc.py against live Oracle, PostgreSQL, MySQL and SQL Server (42 passed on the stack tip)

Resumed audit (2026-11-19)

  • Verified positional C0..CN output, 250/500-column live results, and explicit >500-column error plus projection workaround.
  • Fixed literal boundary quotes being stripped/rejected (e8ab408); added unit regressions and table/query quoted-name coverage.
  • Validation: 49 unit tests and 17 focused live PostgreSQL tests passed; two new unit cases failed before the fix.

Each PR was tested in an isolated worktree at its own remote head plus the additive changes noted above. No restack, sibling integration, merge, or Jira writes were performed; this is not validation of a combined stack.

Generated with Snowflake CoCo

…eader.jdbc

Source column names were emitted raw as Java fields, UDTF output columns and in
the table-mode SELECT list, so spaces, quotes, unicode, keywords or case-only
duplicates failed to compile, and long names made wide tables exceed the UDTF
signature length limit. The UDTF now returns C0..CN and the real names are
restored by alias; table mode reads SELECT * by position.

Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)

Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (yuwang/SNOW-4537770-jdbc-init-in-inference@656c8a4). Learn more about missing BASE report.

Additional details and impacted files
@@                              Coverage Diff                              @@
##             yuwang/SNOW-4537770-jdbc-init-in-inference    #4522   +/-   ##
=============================================================================
  Coverage                                              ?   95.56%           
=============================================================================
  Files                                                 ?      179           
  Lines                                                 ?    47067           
  Branches                                              ?     8148           
=============================================================================
  Hits                                                  ?    44979           
  Misses                                                ?     1301           
  Partials                                              ?      787           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sfc-gh-yuwang and others added 2 commits November 18, 2026 16:45
Report the 500-column limit and projection workaround before read UDTF registration, and cover its boundary.

Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)

Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
Treat JDBC metadata as literal text instead of SQL quoting syntax so boundary quotes are not stripped or rejected. Cover quoted names in query and table modes.

Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)

Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants