Repository navigation
SNOW-4537774: Validate DataFrameReader.jdbc inputs - #4523
Open
sfc-gh-yuwang wants to merge 2 commits into
Open
sfc-gh-yuwang wants to merge 2 commits into
sfc-gh-yuwang wants to merge 2 commits into
Conversation
Raise ValueError for invalid num_partitions, unknown custom_schema columns and a missing imports key (was KeyError); copy udtf_configs packages instead of mutating the caller's list; respect a pinned com.snowflake:snowpark version. Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
sfc-gh-yuwang
requested review from
sfc-gh-aling,
sfc-gh-jzeng and
sfc-gh-yixie
and removed request for
a team
November 18, 2026 18:41
2 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## yuwang/SNOW-4537772-jdbc-column-names #4523 +/- ##
======================================================================
Coverage 95.56% 95.56%
======================================================================
Files 179 179
Lines 47067 47075 +8
Branches 8148 8151 +3
======================================================================
+ Hits 44979 44989 +10
+ Misses 1301 1300 -1
+ Partials 787 786 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 of 11 tasks
…tional packages Reject invalid counts before inference even without a partition column, and retain packages=None compatibility using JDBC's existing defensive copy. Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject invalid JDBC partition counts before inference even without a partition column, reject unknown custom-schema columns and report missing required config as ValueError. Preserve packages=None, avoid mutating package lists and respect Snowpark pins.
SNOW-4537774; stacked on #4522; audit commit fe2f836.
Validation
No merge or restack. Additive ancestor fixes still require normal stack integration.
Generated with Snowflake CoCo