Skip to content

SNOW-4537774: Validate DataFrameReader.jdbc inputs - #4523

Open
sfc-gh-yuwang wants to merge 2 commits into
yuwang/SNOW-4537772-jdbc-column-namesfrom
yuwang/SNOW-4537774-jdbc-validation
Open

sfc-gh-yuwang wants to merge 2 commits into
yuwang/SNOW-4537772-jdbc-column-namesfrom
yuwang/SNOW-4537774-jdbc-validation

Conversation

@sfc-gh-yuwang

@sfc-gh-yuwang sfc-gh-yuwang commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Reject invalid JDBC partition counts before inference even without a partition column, reject unknown custom-schema columns and report missing required config as ValueError. Preserve packages=None, avoid mutating package lists and respect Snowpark pins.

SNOW-4537774; stacked on #4522; audit commit fe2f836.

Validation

  • Six audit regressions fail before and pass after: five counts without column and packages=None.
  • Data-source and adjacent schema parsing tests: 197 passed.
  • Existing tests cover unknown custom-schema columns, missing config keys, package immutability and pins.
  • Pre-commit hooks passed.

No merge or restack. Additive ancestor fixes still require normal stack integration.

Generated with Snowflake CoCo

Raise ValueError for invalid num_partitions, unknown custom_schema columns and
a missing imports key (was KeyError); copy udtf_configs packages instead of
mutating the caller's list; respect a pinned com.snowflake:snowpark version.

Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)

Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
@codecov-commenter

codecov-commenter commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.56%. Comparing base (9c91e35) to head (fe2f836).
⚠️ Report is 2 commits behind head on yuwang/SNOW-4537772-jdbc-column-names.

Additional details and impacted files
@@                          Coverage Diff                           @@
##           yuwang/SNOW-4537772-jdbc-column-names    #4523   +/-   ##
======================================================================
  Coverage                                  95.56%   95.56%           
======================================================================
  Files                                        179      179           
  Lines                                      47067    47075    +8     
  Branches                                    8148     8151    +3     
======================================================================
+ Hits                                       44979    44989   +10     
+ Misses                                      1301     1300    -1     
+ Partials                                     787      786    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…tional packages

Reject invalid counts before inference even without a partition column, and retain packages=None compatibility using JDBC's existing defensive copy.

Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)

Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants