You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This implementation relies on start_date time codes for suspect tests being unique. They basically always are, but this doesn't include any error handling for what happens if there's a conflict for start_date, which will only happen if 2 tests are started in the same second. I tried to add error handling for that, but I ran into an issue where if an admin starts 2 tests at the same time by sending both commands at once in a multiline message, the second command failing would cause both commands to return an error, creating a desync between the showdown server and the loginserver's suspect files. Because of this problem, even if I did add error handling, the desync would still happen, so it wouldn't really fix anything. As far as I can tell, the only way to resolve such a desync is to edit one or both files manually. The bug causing this double error response is deep in some low-level stuff that I don't want to mess with. It should be fine to just not worry about it as long as everyone who's starting suspect tests knows not to start two at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.smogon.com/forums/threads/an-alternate-suspect-test-procedure-that-lets-users-qualify-with-their-main-accounts.3756259/
This will need an accompanying PR to handle the server-side command to reset RD. It won't need a client PR unless sending both true w/l/t and suspect participation w/l/t data in
laddergetis desired.