Suspects: Add a command for old accounts to participate#11991
Open
pyuk-bot wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.smogon.com/forums/threads/an-alternate-suspect-test-procedure-that-lets-users-qualify-with-their-main-accounts.3756259/
This implementation only supports COIL tests for now. It definitely can never support pure Elo tests, since Elo rating doesn't have any built in games-count component, and a GXE + games-count requirement is just COIL again.
A second w/l/t is tracked separately for suspect participation. Those counts are displayed in place of the real ones while an account is participating in an ongoing suspect, but once the suspect is over the real counts will come back. The reset W/L button does not affect these counts.
I have tested everything I can think of, and have added handling for a variety of edge cases, as can be seen in the accompanying loginserver PR: smogon/pokemon-showdown-loginserver#35
Thank you @mia-pi-git for helping me set up the loginserver and MySQL server!