Add replay batch endpoint#28
Merged
Merged
Conversation
SQL magic can just take a list, and the right thing will happen. No need to construct a string.
mia-pi-git
reviewed
Oct 28, 2024
mia-pi-git
reviewed
Oct 28, 2024
Co-authored-by: Mia <49593536+mia-pi-git@users.noreply.github.com>
Co-authored-by: Mia <49593536+mia-pi-git@users.noreply.github.com>
Zarel
reviewed
Nov 12, 2024
Zarel
approved these changes
Nov 12, 2024
Member
Zarel
left a comment
Zarel
left a comment
There was a problem hiding this comment.
After a conversation on Discord and some reflection, I think I'm sold on this being worth it. I'll merge in fiveish days if there are no objections.
Co-authored-by: Guangcong Luo <guangcongluo@gmail.com>
Zarel
reviewed
Nov 13, 2024
Zarel
reviewed
Nov 13, 2024
Contributor
|
Is this okay to merge then? |
Bump |
Contributor
|
Bump |
Member
|
Yes, sorry. |
Member
|
Hi @MCGallaspy, it turns out this PR does not implement inputlog security. As an immediate stopgap, I've entirely omitted inputlogs from its output. If you need them in randbats, you'll need to PR those separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked changes to add batch replay endpoint from #27