Set up Docker env for local development#27
Draft
MCGallaspy wants to merge 6 commits into
Draft
Conversation
These values work with the local dev setup using docker compose.
mia-pi-git
reviewed
Oct 20, 2024
| return {password: pw}; | ||
| }, | ||
|
|
||
| async 'replays/batch.json'(params) { |
Member
There was a problem hiding this comment.
Strike the .json from the name, for loginserver APIs we don't use that.
mia-pi-git
reviewed
Oct 20, 2024
| const ids: string[] = params.ids.split(','); | ||
| const results = await Replays.getBatch(ids); | ||
| console.log(params, ids, results); | ||
| this.response.setHeader('Content-Type', 'application/json'); |
Member
There was a problem hiding this comment.
Suggested change
| this.response.setHeader('Content-Type', 'application/json'); |
This is already handled by the loginserver under the hood.
mia-pi-git
reviewed
Oct 20, 2024
| const results = await Replays.getBatch(ids); | ||
| console.log(params, ids, results); | ||
| this.response.setHeader('Content-Type', 'application/json'); | ||
| return JSON.stringify(results); |
Member
There was a problem hiding this comment.
Suggested change
| return JSON.stringify(results); | |
| return results; |
This is also handled by the loginserver under the hood.
mia-pi-git
reviewed
Oct 20, 2024
| if (!params.ids) { | ||
| throw new ActionError("Invalid batch replay request, must provide ids"); | ||
| } | ||
| const ids: string[] = params.ids.split(','); |
Member
There was a problem hiding this comment.
Probably this should be programatically capped in length here in addition to the query.
mia-pi-git
requested changes
Oct 20, 2024
Member
mia-pi-git
left a comment
mia-pi-git
left a comment
There was a problem hiding this comment.
Please move the batch API endpoint into a new PR. Additionally, I've left feedback on that code.
mia-pi-git
reviewed
Oct 20, 2024
Comment on lines
+244
to
+246
| return replays.selectAll( | ||
| SQL`*` | ||
| )`WHERE private = 0 AND id IN (${idsForQuery}) LIMIT 51`.then(this.toReplays); |
Member
There was a problem hiding this comment.
Suggested change
| return replays.selectAll( | |
| SQL`*` | |
| )`WHERE private = 0 AND id IN (${idsForQuery}) LIMIT 51`.then(this.toReplays); | |
| return replays.selectAll()`WHERE private = 0 AND id IN (${idsForQuery}) LIMIT 51`.then(this.toReplays); |
This is only necessary if you're not selecting * - it defaults to * otherwise.
SQL magic can just take a list, and the right thing will happen. No need to construct a string.
Prevents rebuild when writing e.g. logs to base dir.
Contributor
Author
|
I'll cherry-pick the batch endpoint changes onto a new branch. |
Contributor
Author
|
@mia-pi-git see #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a docker files and compose spec, to enable quickly setting up a dev environment for loginserver testing.
Right now, it starts a loginserver instance, mapping port 8080 on the container to the host, along with a cockroachdb instance.
By running
docker compose up --build --watchyou will build and start both services and can monitor their combined logs on the console. Changing the source files will trigger a rebuild (aka hot reloading).