fix: 'create agent' command to show template, bolt framework, and agent framework options #479
+198
−50
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,38 +71,96 @@ func getSelectionOptions(categoryID string) []promptObject { | |
| return templatePromptObjects[categoryID] | ||
| } | ||
|
|
||
| // getFrameworkOptions returns the framework choices for a given AI app template. | ||
| func getFrameworkOptions(template string) []promptObject { | ||
| frameworkPromptObjects := map[string][]promptObject{ | ||
| "slack-cli#ai-apps/support-agent": { | ||
| { | ||
| Title: fmt.Sprintf("Bolt for JavaScript %s", style.Secondary("Node.js")), | ||
| Repository: "slack-cli#ai-apps/support-agent/bolt-js", | ||
| }, | ||
| { | ||
| Title: fmt.Sprintf("Bolt for Python %s", style.Secondary("Python")), | ||
| Repository: "slack-cli#ai-apps/support-agent/bolt-python", | ||
| }, | ||
| }, | ||
| "slack-cli#ai-apps/starter-agent": { | ||
| { | ||
| Title: fmt.Sprintf("Bolt for JavaScript %s", style.Secondary("Node.js")), | ||
| Repository: "slack-cli#ai-apps/starter-agent/bolt-js", | ||
| }, | ||
| { | ||
| Title: fmt.Sprintf("Bolt for Python %s", style.Secondary("Python")), | ||
| Repository: "slack-cli#ai-apps/starter-agent/bolt-python", | ||
| }, | ||
| }, | ||
| } | ||
| return frameworkPromptObjects[template] | ||
| } | ||
|
|
||
| // getAdapterOptions returns the AI adapter choices for a given template and framework. | ||
| func getAdapterOptions(framework string) []promptObject { | ||
| adapterPromptObjects := map[string][]promptObject{ | ||
| "slack-cli#ai-apps/support-agent/bolt-js": { | ||
| { | ||
| Title: "Claude Agent SDK", | ||
|
||
| Repository: "slack-samples/bolt-js-support-agent", | ||
| Subdir: "claude-agent-sdk", | ||
| }, | ||
| { | ||
| Title: "OpenAI Agents SDK", | ||
| Repository: "slack-samples/bolt-js-support-agent", | ||
| Subdir: "openai-agents-sdk", | ||
| }, | ||
| }, | ||
| "slack-cli#ai-apps/support-agent/bolt-python": { | ||
| { | ||
| Title: "Claude Agent SDK", | ||
| Repository: "slack-samples/bolt-python-support-agent", | ||
| Subdir: "claude-agent-sdk", | ||
| }, | ||
| { | ||
| Title: "OpenAI Agents SDK", | ||
| Repository: "slack-samples/bolt-python-support-agent", | ||
| Subdir: "openai-agents-sdk", | ||
| }, | ||
| { | ||
| Title: "Pydantic AI", | ||
| Repository: "slack-samples/bolt-python-support-agent", | ||
| Subdir: "pydantic-ai", | ||
| }, | ||
| }, | ||
| "slack-cli#ai-apps/starter-agent/bolt-js": { | ||
| { | ||
| Title: "Claude Agent SDK", | ||
| Repository: "slack-samples/bolt-js-starter-agent", | ||
| Subdir: "claude-agent-sdk", | ||
| }, | ||
| { | ||
| Title: "OpenAI Agents SDK", | ||
| Repository: "slack-samples/bolt-js-starter-agent", | ||
| Subdir: "openai-agents-sdk", | ||
| }, | ||
| }, | ||
| "slack-cli#ai-apps/starter-agent/bolt-python": { | ||
| { | ||
| Title: "Claude Agent SDK", | ||
| Repository: "slack-samples/bolt-python-starter-agent", | ||
| Subdir: "claude-agent-sdk", | ||
| }, | ||
| { | ||
| Title: "OpenAI Agents SDK", | ||
| Repository: "slack-samples/bolt-python-starter-agent", | ||
| Subdir: "openai-agents-sdk", | ||
| }, | ||
| { | ||
| Title: "Pydantic AI", | ||
| Repository: "slack-samples/bolt-python-starter-agent", | ||
| Subdir: "pydantic-ai", | ||
| }, | ||
| }, | ||
| } | ||
| return adapterPromptObjects[framework] | ||
| } | ||
|
|
||
| // getSelectionOptionsForCategory returns the top-level category options for | ||
|
|
@@ -223,31 +281,63 @@ func promptTemplateSelection(cmd *cobra.Command, clients *shared.ClientFactory, | |
| } | ||
| template := options[selection.Index].Repository | ||
|
|
||
| // Prompt for the framework | ||
| frameworks := getFrameworkOptions(template) | ||
| frameworkChoices := make([]string, len(frameworks)) | ||
| for i, opt := range frameworks { | ||
| frameworkChoices[i] = opt.Title | ||
| } | ||
| frameworkSelection, err := clients.IO.SelectPrompt(ctx, "Select a framework:", frameworkChoices, iostreams.SelectPromptConfig{ | ||
| Description: func(value string, index int) string { | ||
| return frameworks[index].Description | ||
| }, | ||
| Required: true, | ||
| Template: getSelectionTemplate(clients), | ||
| }) | ||
| if err != nil { | ||
| return create.Template{}, err | ||
| } else if frameworkSelection.Flag { | ||
| return create.Template{}, slackerror.New(slackerror.ErrPrompt) | ||
| } | ||
| framework := frameworks[frameworkSelection.Index] | ||
|
|
||
| // Check if there are adapter options for this framework | ||
| adapters := getAdapterOptions(framework.Repository) | ||
| if len(adapters) > 0 { | ||
| adapterChoices := make([]string, len(adapters)) | ||
| for i, opt := range adapters { | ||
| adapterChoices[i] = opt.Title | ||
| } | ||
| adapterSelection, err := clients.IO.SelectPrompt(ctx, "Select an adapter:", adapterChoices, iostreams.SelectPromptConfig{ | ||
zimeg marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| Description: func(value string, index int) string { | ||
| return adapters[index].Description | ||
| }, | ||
| Required: true, | ||
| Template: getSelectionTemplate(clients), | ||
| }) | ||
| if err != nil { | ||
| return create.Template{}, err | ||
| } else if adapterSelection.Flag { | ||
| return create.Template{}, slackerror.New(slackerror.ErrPrompt) | ||
| } | ||
| adapter := adapters[adapterSelection.Index] | ||
| resolved, err := create.ResolveTemplateURL(adapter.Repository) | ||
| if err != nil { | ||
| return create.Template{}, err | ||
| } | ||
| if adapter.Subdir != "" { | ||
| resolved.SetSubdir(adapter.Subdir) | ||
| } | ||
| return resolved, nil | ||
| } | ||
|
|
||
| // No adapter options - resolve the framework directly | ||
| resolved, err := create.ResolveTemplateURL(framework.Repository) | ||
| if err != nil { | ||
| return create.Template{}, err | ||
| } | ||
| if framework.Subdir != "" { | ||
| resolved.SetSubdir(framework.Subdir) | ||
| } | ||
| return resolved, nil | ||
| } | ||
|
|
@@ -315,12 +405,18 @@ func listTemplates(ctx context.Context, clients *shared.ClientFactory, categoryS | |
| for _, category := range categories { | ||
| var secondary []string | ||
| if frameworks := getFrameworkOptions(category.id); len(frameworks) > 0 { | ||
| for _, fw := range frameworks { | ||
| if adapters := getAdapterOptions(fw.Repository); len(adapters) > 0 { | ||
| for _, adapter := range adapters { | ||
| repo := adapter.Repository | ||
| if adapter.Subdir != "" { | ||
| repo = fmt.Sprintf("%s --subdir %s", repo, adapter.Subdir) | ||
| } | ||
| secondary = append(secondary, repo) | ||
| } | ||
| } else { | ||
| secondary = append(secondary, fw.Repository) | ||
| } | ||
| } | ||
| } else { | ||
| for _, tmpl := range getSelectionOptions(category.id) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: We originally brainstormed having the Secondary display the breadcrumb of the previous selection. I'm just curious why you decided to not include that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks Forgive this was omitted until comments below and e82f2a9! 🙏 ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zimeg Thanks, this is much better! 🙇🏻