-
Notifications
You must be signed in to change notification settings - Fork 32
Expand file tree
/
Copy pathcreate_test.go
More file actions
851 lines (833 loc) · 35.4 KB
/
create_test.go
File metadata and controls
851 lines (833 loc) · 35.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
// Copyright 2022-2026 Salesforce, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package project
import (
"context"
"testing"
"github.com/slackapi/slack-cli/internal/config"
"github.com/slackapi/slack-cli/internal/iostreams"
"github.com/slackapi/slack-cli/internal/pkg/create"
"github.com/slackapi/slack-cli/internal/shared"
"github.com/slackapi/slack-cli/internal/slackerror"
"github.com/slackapi/slack-cli/test/testutil"
"github.com/spf13/cobra"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
)
type CreateClientMock struct {
mock.Mock
}
func (m *CreateClientMock) Create(ctx context.Context, clients *shared.ClientFactory, createArgs create.CreateArgs) (string, error) {
args := m.Called(ctx, clients, createArgs)
return args.String(0), args.Error(1)
}
func TestCreateCommand(t *testing.T) {
var createClientMock *CreateClientMock
testutil.TableTestCommand(t, testutil.CommandTests{
"creates a bolt application from prompts": {
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("IsTTY").Return(true)
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
cm.IO.On("InputPrompt", mock.Anything, "Name your app:", mock.Anything).
Return("my-app", nil)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-template")
require.NoError(t, err)
expected := create.CreateArgs{
AppName: "my-app",
Template: template,
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
cm.IO.AssertCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"creates a deno application from flags": {
CmdArgs: []string{"--template", "slack-samples/deno-starter-template"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("IsTTY").Return(true)
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/deno-starter-template",
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/deno-starter-template",
},
nil,
)
cm.IO.On("InputPrompt", mock.Anything, "Name your app:", mock.Anything).
Return("my-deno-app", nil)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/deno-starter-template")
require.NoError(t, err)
expected := create.CreateArgs{
AppName: "my-deno-app",
Template: template,
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
cm.IO.AssertCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"creates an agent app using agent argument shortcut": {
CmdArgs: []string{"agent"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("IsTTY").Return(true)
// Should skip category prompt and go directly to template selection
cm.IO.On("SelectPrompt", mock.Anything, "Select a template:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 1, // Select Starter Agent
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Node.js
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select an adapter:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Claude Agent SDK
},
nil,
)
cm.IO.On("InputPrompt", mock.Anything, "Name your app:", mock.Anything).
Return("my-agent", nil)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-agent")
require.NoError(t, err)
template.SetSubdir("claude-agent-sdk")
expected := create.CreateArgs{
AppName: "my-agent",
Template: template,
Subdir: "claude-agent-sdk",
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that category prompt was NOT called
cm.IO.AssertNotCalled(t, "SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything)
cm.IO.AssertCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"creates an agent app with app name using agent argument": {
CmdArgs: []string{"agent", "my-agent-app"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
// Should skip category prompt and go directly to template selection
cm.IO.On("SelectPrompt", mock.Anything, "Select a template:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 1, // Select Starter Agent
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 1, // Select Python
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select an adapter:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Claude Agent SDK
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-python-starter-agent")
require.NoError(t, err)
template.SetSubdir("claude-agent-sdk")
expected := create.CreateArgs{
AppName: "my-agent-app",
Template: template,
Subdir: "claude-agent-sdk",
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that category prompt was NOT called
cm.IO.AssertNotCalled(t, "SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything)
// Verify that name prompt was NOT called since name was provided as arg
cm.IO.AssertNotCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"creates a pydantic ai agent app": {
CmdArgs: []string{"my-pydantic-app"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(iostreams.SelectPromptResponse{Prompt: true, Index: 1}, nil)
cm.IO.On("SelectPrompt", mock.Anything, "Select a template:", mock.Anything, mock.Anything).
Return(iostreams.SelectPromptResponse{Prompt: true, Index: 0}, nil)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(iostreams.SelectPromptResponse{Prompt: true, Index: 1}, nil) // Select Bolt for Python
cm.IO.On("SelectPrompt", mock.Anything, "Select an adapter:", mock.Anything, mock.Anything).
Return(iostreams.SelectPromptResponse{Prompt: true, Index: 2}, nil) // Select Pydantic AI
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-python-support-agent")
require.NoError(t, err)
template.SetSubdir("pydantic-ai")
expected := create.CreateArgs{
AppName: "my-pydantic-app",
Template: template,
Subdir: "pydantic-ai",
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
},
},
"creates an app named agent when template flag is provided": {
CmdArgs: []string{"agent", "--template", "slack-samples/bolt-js-starter-template"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/bolt-js-starter-template",
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/bolt-js-starter-template",
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-template")
require.NoError(t, err)
expected := create.CreateArgs{
AppName: "agent",
Template: template,
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that name prompt was NOT called since name was provided as arg
cm.IO.AssertNotCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"creates an app named agent using name flag without triggering shortcut": {
CmdArgs: []string{"--name", "agent"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
// Should prompt for category since agent shortcut is NOT triggered
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select starter app
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Node.js
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-template")
require.NoError(t, err)
expected := create.CreateArgs{
AppName: "agent",
Template: template,
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that category prompt WAS called (shortcut was not triggered)
cm.IO.AssertCalled(t, "SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything)
// Verify that name prompt was NOT called since --name flag was provided
cm.IO.AssertNotCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"creates an agent app with name flag overriding positional arg": {
CmdArgs: []string{"agent", "--name", "my-custom-name"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
// Should skip category prompt due to agent shortcut
cm.IO.On("SelectPrompt", mock.Anything, "Select a template:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 1, // Select Starter Agent
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Node.js
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select an adapter:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Claude Agent SDK
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-agent")
require.NoError(t, err)
template.SetSubdir("claude-agent-sdk")
expected := create.CreateArgs{
AppName: "my-custom-name", // --name flag overrides
Template: template,
Subdir: "claude-agent-sdk",
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that category prompt was NOT called (shortcut was triggered)
cm.IO.AssertNotCalled(t, "SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything)
},
},
"name flag overrides positional app name argument": {
CmdArgs: []string{"my-project", "--name", "my-name"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select starter app
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Node.js
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-template")
require.NoError(t, err)
expected := create.CreateArgs{
AppName: "my-name", // --name flag overrides "my-project" positional arg
Template: template,
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that name prompt was NOT called since --name flag was provided
cm.IO.AssertNotCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"name flag overrides positional app name argument with agent shortcut": {
CmdArgs: []string{"agent", "my-project", "--name", "my-name"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
// Should skip category prompt due to agent shortcut
cm.IO.On("SelectPrompt", mock.Anything, "Select a template:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 1, // Select Starter Agent
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Node.js
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select an adapter:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0, // Select Claude Agent SDK
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-agent")
require.NoError(t, err)
template.SetSubdir("claude-agent-sdk")
expected := create.CreateArgs{
AppName: "my-name", // --name flag overrides "my-project" positional arg
Template: template,
Subdir: "claude-agent-sdk",
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that category prompt was NOT called (agent shortcut was triggered)
cm.IO.AssertNotCalled(t, "SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything)
// Verify that name prompt was NOT called since --name flag was provided
cm.IO.AssertNotCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"name prompt includes placeholder with generated name": {
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("IsTTY").Return(true)
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
cm.IO.On("InputPrompt", mock.Anything, "Name your app:", mock.Anything).
Return("my-app", nil)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
// Verify that InputPrompt was called with a config that has a non-empty Placeholder
cm.IO.AssertCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.MatchedBy(func(cfg iostreams.InputPromptConfig) bool {
return cfg.Placeholder != ""
}))
},
},
"user accepts default name from prompt": {
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("IsTTY").Return(true)
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
// Return empty string to simulate pressing Enter (accepting default)
cm.IO.On("InputPrompt", mock.Anything, "Name your app:", mock.Anything).
Return("", nil)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
cm.IO.AssertCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
// When the user accepts the default (empty return), the generated name is used
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, mock.MatchedBy(func(args create.CreateArgs) bool {
return args.AppName != ""
}))
},
},
"non-TTY without name falls back to generated name": {
CmdArgs: []string{"--template", "slack-samples/bolt-js-starter-template"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
// IsTTY defaults to false via AddDefaultMocks, simulating piped output
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/bolt-js-starter-template",
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/bolt-js-starter-template",
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
// Should NOT prompt for name since not a TTY
cm.IO.AssertNotCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
// Should still call Create with a non-empty generated name
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, mock.MatchedBy(func(args create.CreateArgs) bool {
return args.AppName != ""
}))
},
},
"positional arg skips name prompt": {
CmdArgs: []string{"my-project"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Prompt: true,
Index: 0,
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-template")
require.NoError(t, err)
expected := create.CreateArgs{
AppName: "my-project",
Template: template,
}
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, expected)
// Verify that name prompt was NOT called since name was provided as positional arg
cm.IO.AssertNotCalled(t, "InputPrompt", mock.Anything, "Name your app:", mock.Anything)
},
},
"subdir without template flag returns error": {
CmdArgs: []string{"--subdir", "apps/my-app"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
createClientMock = new(CreateClientMock)
CreateFunc = createClientMock.Create
},
ExpectedErrorStrings: []string{"The --subdir flag requires the --template flag"},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
createClientMock.AssertNotCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything)
},
},
"passes subdir flag to create function": {
CmdArgs: []string{"--template", "slack-samples/bolt-js-starter-template", "--subdir", "apps/my-app"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
cm.IO.On("SelectPrompt", mock.Anything, "Select a category:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/bolt-js-starter-template",
},
nil,
)
cm.IO.On("SelectPrompt", mock.Anything, "Select a framework:", mock.Anything, mock.Anything).
Return(
iostreams.SelectPromptResponse{
Flag: true,
Option: "slack-samples/bolt-js-starter-template",
},
nil,
)
createClientMock = new(CreateClientMock)
createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything).Return("", nil)
CreateFunc = createClientMock.Create
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-template")
require.NoError(t, err)
createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, mock.MatchedBy(func(args create.CreateArgs) bool {
return args.AppName != "" && args.Template == template && args.Subdir == "apps/my-app"
}))
},
},
"list flag ignores subdir": {
CmdArgs: []string{"--list", "--subdir", "foo"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
createClientMock = new(CreateClientMock)
CreateFunc = createClientMock.Create
},
ExpectedOutputs: []string{
"Getting started",
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
createClientMock.AssertNotCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything)
},
},
"lists all templates with --list flag": {
CmdArgs: []string{"--list"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
createClientMock = new(CreateClientMock)
CreateFunc = createClientMock.Create
},
ExpectedOutputs: []string{
"Getting started",
"slack-samples/bolt-js-starter-template",
"slack-samples/bolt-python-starter-template",
"Support agent",
"slack-samples/bolt-js-support-agent --subdir claude-agent-sdk",
"slack-samples/bolt-js-support-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-support-agent --subdir claude-agent-sdk",
"slack-samples/bolt-python-support-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-support-agent --subdir pydantic-ai",
"Starter agent",
"slack-samples/bolt-js-starter-agent --subdir claude-agent-sdk",
"slack-samples/bolt-js-starter-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-starter-agent --subdir claude-agent-sdk",
"slack-samples/bolt-python-starter-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-starter-agent --subdir pydantic-ai",
"Automation apps",
"slack-samples/bolt-js-custom-function-template",
"slack-samples/bolt-python-custom-function-template",
"slack-samples/deno-starter-template",
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
createClientMock.AssertNotCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything)
},
},
"lists agent templates with agent --list flag": {
CmdArgs: []string{"agent", "--list"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
createClientMock = new(CreateClientMock)
CreateFunc = createClientMock.Create
},
ExpectedOutputs: []string{
"Support agent",
"slack-samples/bolt-js-support-agent --subdir claude-agent-sdk",
"slack-samples/bolt-js-support-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-support-agent --subdir claude-agent-sdk",
"slack-samples/bolt-python-support-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-support-agent --subdir pydantic-ai",
"Starter agent",
"slack-samples/bolt-js-starter-agent --subdir claude-agent-sdk",
"slack-samples/bolt-js-starter-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-starter-agent --subdir claude-agent-sdk",
"slack-samples/bolt-python-starter-agent --subdir openai-agents-sdk",
"slack-samples/bolt-python-starter-agent --subdir pydantic-ai",
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
createClientMock.AssertNotCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything)
output := cm.GetCombinedOutput()
assert.NotContains(t, output, "Getting started")
assert.NotContains(t, output, "Automation apps")
},
},
}, func(cf *shared.ClientFactory) *cobra.Command {
return NewCreateCommand(cf)
})
}
func TestCreateCommand_confirmExternalTemplateSelection(t *testing.T) {
// test cases
tests := map[string]struct {
templateSource string
setup func(cm *shared.ClientsMock, scm *config.SystemConfigMock)
expect func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock)
}{
"trust, untrusted source": {
templateSource: "untrusted-source/app",
setup: func(cm *shared.ClientsMock, scm *config.SystemConfigMock) {
scm.On("GetTrustUnknownSources", mock.Anything).Return(true, nil)
},
expect: func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock) {
assert.True(t, confirmed)
if err != nil {
assert.Fail(t, "selection should be confirmed")
}
// Should not have prompted
output := cm.GetCombinedOutput()
assert.NotContains(t, output, "You are trying to use code published by an unknown author")
},
},
"don't trust, trusted source": {
templateSource: "slack-samples/app",
setup: func(cm *shared.ClientsMock, scm *config.SystemConfigMock) {
scm.On("GetTrustUnknownSources", mock.Anything).Return(false, nil)
},
expect: func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock) {
assert.True(t, confirmed)
if err != nil {
assert.Fail(t, "should confirm the selection despite not trusting source since template source is trusted")
}
},
},
"don't trust, untrusted source, confirm": {
templateSource: "untrusted-source/app",
setup: func(cm *shared.ClientsMock, scm *config.SystemConfigMock) {
scm.On("GetTrustUnknownSources", mock.Anything).Return(false, nil)
cm.IO.On("SelectPrompt", mock.Anything, "Proceed?", mock.Anything, mock.Anything).Return(iostreams.SelectPromptResponse{Index: 0, Option: "Yes"}, nil)
},
expect: func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock) {
assert.True(t, confirmed)
if err != nil {
assert.Fail(t, "should prompt")
}
// Should have prompted
output := cm.GetCombinedOutput()
assert.Contains(t, output, "You are trying to use code published by an unknown author")
},
},
"don't trust, untrusted source, do not confirm": {
templateSource: "untrusted-source/app",
setup: func(cm *shared.ClientsMock, scm *config.SystemConfigMock) {
scm.On("GetTrustUnknownSources", mock.Anything).Return(false, nil)
cm.IO.On("SelectPrompt", mock.Anything, "Proceed?", mock.Anything, mock.Anything).Return(iostreams.SelectPromptResponse{Index: 2, Option: "No"}, nil)
},
expect: func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock) {
assert.False(t, confirmed)
if err != nil {
assert.Fail(t, "should have returned with no error")
}
// Should have prompted
output := cm.GetCombinedOutput()
assert.Contains(t, output, "You are trying to use code published by an unknown author")
},
},
"don't trust, untrusted source, confirm and don't ask again": {
templateSource: "untrusted-source/app",
setup: func(cm *shared.ClientsMock, scm *config.SystemConfigMock) {
scm.On("GetTrustUnknownSources", mock.Anything).Return(false, nil)
scm.On("SetTrustUnknownSources", mock.Anything, true).Return(nil)
// Proceed when prompted and select don't ask again
cm.IO.On("SelectPrompt", mock.Anything, "Proceed?", mock.Anything, mock.Anything).Return(iostreams.SelectPromptResponse{Index: 1, Option: "Yes, don't ask again"}, nil)
},
expect: func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock) {
// Should have prompted
output := cm.GetCombinedOutput()
assert.Contains(t, output, "You are trying to use code published by an unknown author")
// should have confirmed
assert.True(t, confirmed)
if err != nil {
assert.Fail(t, "should have returned with no error")
}
// Should have tried to set the source after confirmation
scm.AssertCalled(t, "SetTrustUnknownSources", mock.Anything, true)
},
},
"don't trust, untrusted source, confirm and prompt error": {
templateSource: "untrusted-source/app",
setup: func(cm *shared.ClientsMock, scm *config.SystemConfigMock) {
scm.On("GetTrustUnknownSources", mock.Anything).Return(false, nil)
scm.On("SetTrustUnknownSources", mock.Anything, true).Return(nil)
// Proceed when prompted, don't ask again
cm.IO.On("SelectPrompt", mock.Anything, "Proceed?", mock.Anything, mock.Anything).Return(iostreams.SelectPromptResponse{Index: 1, Option: "Yes, don't ask again"}, slackerror.New("error"))
},
expect: func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock) {
// does not return confirmed
assert.False(t, confirmed)
if err == nil {
assert.Fail(t, "should have returned the prompt error")
}
// Should not have tried to set the source after confirmation
scm.AssertNotCalled(t, "SetTrustUnknownSources", mock.Anything, true)
},
},
"don't trust sources, untrusted source, confirm and config write error": {
templateSource: "untrusted-source/app",
setup: func(cm *shared.ClientsMock, scm *config.SystemConfigMock) {
scm.On("GetTrustUnknownSources", mock.Anything).Return(false, nil)
// Set trust_unknown_sources should fail with an error
scm.On("SetTrustUnknownSources", mock.Anything, true).Return(slackerror.New("an error!"))
// Proceed when prompted, select don't ask again
cm.IO.On("SelectPrompt", mock.Anything, "Proceed?", mock.Anything, mock.Anything).Return(iostreams.SelectPromptResponse{Index: 1, Option: "Yes, don't ask again"}, nil)
},
expect: func(confirmed bool, err error, cm *shared.ClientsMock, scm *config.SystemConfigMock) {
// should confirm with an error
assert.True(t, confirmed)
if err == nil {
assert.Fail(t, "should have returned an error")
}
assert.ErrorContains(t, err, "an error!")
},
},
}
// test!
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
// setup
cm := shared.NewClientsMock()
cm.AddDefaultMocks()
scm := &config.SystemConfigMock{}
tc.setup(cm, scm)
cm.Config.SystemConfig = scm
clients := shared.NewClientFactory(cm.MockClientFactory())
cmd := NewCreateCommand(clients)
testutil.MockCmdIO(clients.IO, cmd)
// test
template, err := create.ResolveTemplateURL(tc.templateSource)
require.NoError(t, err)
confirmed, err := confirmExternalTemplateSelection(cmd, clients, template)
tc.expect(confirmed, err, cm, scm)
})
}
}