refactor: erase configuration from interned storage#1204
Open
MichaReiser wants to merge 10 commits into
Open
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
Merging this PR will not alter performance
Comparing Footnotes
|
MichaReiser
commented
Jun 28, 2026
| /// `memo_table` must belong to the value identified by `id` in `ingredient_index` and must | ||
| /// have been created with `memo_table_types`. The caller must have exclusive access to the | ||
| /// table. | ||
| unsafe fn inner( |
Contributor
Author
There was a problem hiding this comment.
Only change is that the code moved into this inner function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erases configuration from interned storage and cold paths to reduce downstream monomorphization while retaining specialized reuse checks on the successful-hit path.
Measured on ty:
new[InternedInput]simulation improves from 598 to 597 instructions