Skip to content

refactor: erase configuration from interned storage#1204

Open
MichaReiser wants to merge 10 commits into
salsa-rs:masterfrom
MichaReiser:erase-interned-configuration
Open

refactor: erase configuration from interned storage#1204
MichaReiser wants to merge 10 commits into
salsa-rs:masterfrom
MichaReiser:erase-interned-configuration

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Erases configuration from interned storage and cold paths to reduce downstream monomorphization while retaining specialized reuse checks on the successful-hit path.

Measured on ty:

  • total LLVM lines fall from 3,284,622 to 3,096,046 (5.74%)
  • intern-related LLVM lines from 276,433 to 216,077 (21.83%)
  • DateType instructions from 674,414,109 to 673,205,080 (0.179%).
  • The Salsa new[InternedInput] simulation improves from 598 to 597 instructions
  • the debug ty binary falls by 3.38%
  • the stripped release binary by 1.25%
  • the maturin wheel by 0.84%.

@netlify

netlify Bot commented Jun 27, 2026

Copy link
Copy Markdown

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 132d710
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/6a40f7dd6e366300082538ee

@codspeed-hq

codspeed-hq Bot commented Jun 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks
🗄️ 22 archived benchmarks run1


Comparing MichaReiser:erase-interned-configuration (132d710) with master (b826c8c)

Open in CodSpeed

Footnotes

  1. 22 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

Comment thread src/interned.rs
/// `memo_table` must belong to the value identified by `id` in `ingredient_index` and must
/// have been created with `memo_table_types`. The caller must have exclusive access to the
/// table.
unsafe fn inner(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change is that the code moved into this inner function

@MichaReiser MichaReiser marked this pull request as ready for review June 28, 2026 11:17
@MichaReiser MichaReiser requested a review from ibraheemdev June 28, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant