refactor: reduce interned constructor monomorphization#1208
Draft
MichaReiser wants to merge 11 commits into
Draft
refactor: reduce interned constructor monomorphization#1208MichaReiser wants to merge 11 commits into
MichaReiser wants to merge 11 commits into
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves interned shard construction behind a non-generic helper so the compiler emits the
OnceLockand iterator machinery once instead of per configuration.Relative to #1204, using LLVM IR for
ty_python_semanticdrops from 3,988,276 to 3,921,670 lines: 66,606 fewer (-1.67%).This PR is stacked on #1204, which makes the constructor independent of
C.Ready for review once 1204 lands
Testing: Focused tests, formatting, LLVM-line analysis, and CodSpeed simulation passed.