Skip to content

fix: prevent update diagnostics from showing for matching pre-releases #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saecki merged 2 commits into from
May 13, 2025
Merged

fix: prevent update diagnostics from showing for matching pre-releases #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0754415
fix: prevent update diagnostics from showing for matching pre-releases
happenslol May 13, 2025
b5956a0
refactor: change get_newest to allow selecting pre-releases when reqs…
saecki May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lua/crates/diagnostic.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,8 @@ end
---@return CrateInfo
function M.process_api_crate(crate, api_crate, diagnostics)
local versions = api_crate and api_crate.versions
local newest, newest_pre, newest_yanked = util.get_newest(versions, nil)
local allow_pre = semver.allows_pre(crate:vers_reqs())
local newest, newest_pre, newest_yanked = util.get_newest(versions, nil, allow_pre)
newest = newest or newest_pre or newest_yanked

---@type CrateInfo
Expand Down
5 changes: 3 additions & 2 deletions lua/crates/util.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,16 @@ end

---@param versions ApiVersion[]?
---@param reqs Requirement[]?
---@param allow_pre boolean? -- fallback to use when `reqs` is nil
---@return ApiVersion?
---@return ApiVersion?
---@return ApiVersion?
function M.get_newest(versions, reqs)
function M.get_newest(versions, reqs, allow_pre)
if not versions or not next(versions) then
return nil
end

local allow_pre = reqs and semver.allows_pre(reqs) or false
allow_pre = reqs and semver.allows_pre(reqs) or allow_pre or false

---@type ApiVersion?, ApiVersion?, ApiVersion?
local newest_yanked, newest_pre, newest
Expand Down
Loading