fix: prevent update diagnostics from showing for matching pre-releases#162
Merged
saecki merged 2 commits intosaecki:mainfrom May 13, 2025
Merged
Conversation
Owner
|
Can you give an example of where that would be the case? I'm not quite sure I understand 🤔 Edit: never mind I've figured it out |
Owner
|
You were complete right, I've just changed things up a bit. CI is failing because of, uhhhm reasons... |
Contributor
Author
Cool, thanks for merging! The way you refactored it was the other possibility I considered 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user requests a pre-release (e.g.
crate = "1.0.0-alpha.3"), an update diagnostic was shown to the user even if the requested pre-release was the newest release.This makes sure that both
newestandnewest_preare considered when checking if the newest found version is matched by the user's requirements.