Skip to content

Cleanup rustdoc-html tests - #164925

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
GuillaumeGomez:cleanup-rustdoc-html-tests
Oct 26, 2026
Merged

Cleanup rustdoc-html tests#164925
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
GuillaumeGomez:cleanup-rustdoc-html-tests

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Oct 25, 2026

Copy link
Copy Markdown
Member

r? @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 25, 2026
Urgau
Urgau approved these changes Oct 25, 2026
View reviewed changes

@Urgau Urgau left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f0fa4d1 has been approved by Urgau

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#164925 - GuillaumeGomez:cleanup-rustdoc-htm…
54bf220 
…l-tests, r=Urgau

Cleanup `rustdoc-html` tests

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 26, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#164925 - GuillaumeGomez:cleanup-rustdoc-htm…
89b66c2 
…l-tests, r=Urgau

Cleanup `rustdoc-html` tests

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 26, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
@bors
Auto merge of #164940 - JonathanBrouwer:rollup-rCORLRu, r=JonathanBro…
9cd92f4 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #164617 (tools: remote-test-server: Fix UEFI crash return code)
 - #164549 (feat!: change return type of `TryFromIntError::kind`)
 - #164893 (Add diagnostic items for env::vars / env::vars_os)
 - #164897 (Add regression test for CoerceShared impl with unnormalizable target)
 - #164908 (Add regression test for self referential inherent associated type ICE)
 - #164925 (Cleanup `rustdoc-html` tests)
@jhpratt

jhpratt commented Oct 26, 2026

Copy link
Copy Markdown
Member

@bors r- #164940 (comment)

..                                                 (152/152)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 182: ProtocolError: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.: for command `click: "//*[@id='method.create_an_iterator_from_read']//*[@class='tooltip']"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 38: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

I'm not 100% on this, but I'm excluding it from the next rollup while a try job runs.

@bors try jobs=test-x86_64-gnu-tools

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2026
@rust-bors

rust-bors Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#164940), which was unapproved.

View changes since this unapproval

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
@bors
Auto merge of #164925 - GuillaumeGomez:cleanup-rustdoc-html-tests, r=…
ab79f98 
…<try>

Cleanup `rustdoc-html` tests


try-job: test-x86_64-gnu-tools
@rust-bors

rust-bors Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: ab79f98 (ab79f98568fabc93608d9584892a6c7ae52cdee8)
Base parent: 8592206 (859220648edee0282af5b56f0b490cd4beb074db)

@jhpratt

jhpratt commented Oct 26, 2026

Copy link
Copy Markdown
Member

Guess it was spurious.

@bors r=Urgau

@rust-bors

rust-bors Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f0fa4d1 has been approved by Urgau

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 26, 2026
@jhpratt
Rollup merge of rust-lang#164925 - GuillaumeGomez:cleanup-rustdoc-htm…
8f4d8dc 
…l-tests, r=Urgau

Cleanup `rustdoc-html` tests

r? @Urgau
@jhpratt jhpratt mentioned this pull request Oct 26, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#164925 - GuillaumeGomez:cleanup-rustdoc-htm…
4f6f680 
…l-tests, r=Urgau

Cleanup `rustdoc-html` tests

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 26, 2026
Closed
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 26, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
@bors
Auto merge of #164964 - JonathanBrouwer:rollup-gEwXdy7, r=JonathanBro…
019b59d 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #164790 (Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`)
 - #163952 (Remove ignore-unsafe tidy check in alloc/linklist)
 - #164691 (Minor lints and performance improvements for LLDB visualizers)
 - #164925 (Cleanup `rustdoc-html` tests)
 - #164941 (Update actions/setup-python action to v7.1.0)
@rust-bors
rust-bors Bot merged commit 7221b89 into rust-lang:main Oct 26, 2026
15 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
@bors
Unrolled build for #164925 in rollup 164964
623a644 
Rollup merge of #164925 - GuillaumeGomez:cleanup-rustdoc-html-tests, r=Urgau

Cleanup `rustdoc-html` tests

r? @Urgau
@GuillaumeGomez
GuillaumeGomez deleted the cleanup-rustdoc-html-tests branch October 26, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @jhpratt @Urgau @rustbot