Repository navigation
Rollup of 3 pull requests - #164959
Closed
jhpratt wants to merge 8 commits into
Closed
Rollup of 3 pull requests#164959jhpratt wants to merge 8 commits into
jhpratt wants to merge 8 commits into
Conversation
The original `nonzero_ops` feature (rust-lang#84186) was stabilized before the `strict_*` methods on the regular integer types, so the inclusion of the `strict` methods on `NonZero` type was left as future work. Some users (see e.g. rust-lang#84186 (comment)) have recently requested these methods, and it's good to have them for consistency.
To avoid further duplication in `nonzero.rs`, this new set of tests is
generated by macros similar to those used for the primitive integer
types in `coretests/tests/num/{u,}int_macros.rs`. Many of the tests in
`nonzero.rs` are good candidates to be moved to the new
`nonzero_{u,}int_module` macros, but that's left as future work.
…hrat011899 Remove ignore-unsafe tidy check in alloc/linklist This PR remove all `ignore-tidy-undocumented-unsafe` in `alloc/src/collections/linked_list.rs`. All unsafe call-sites are checked. Besides, this PR adds missing document comments for two unsafe functions(although they are private). If there exists anything need to be modified, I will update this PR.
Add `strict_` methods to `NonZero` The original `nonzero_ops` feature (rust-lang#84186) was stabilized before the `strict_*` methods on the regular integer types, so the inclusion of the `strict` methods on `NonZero` type was left as future work. Some users (see e.g. rust-lang#84186 (comment)) have recently requested these methods, and it's good to have them for consistency.
…l-tests, r=Urgau Cleanup `rustdoc-html` tests r? @Urgau
rustbot
added
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
strict_methods toNonZero#164848 (Addstrict_methods toNonZero)rustdoc-htmltests #164925 (Cleanuprustdoc-htmltests)Warning
This rollup conflicts with pending auto build #164957 and may need to be recreated if the pending build succeeds.
r? @ghost
Create a similar rollup