Remove ignore-unsafe tidy check in alloc/linklist by yilin0518 · Pull Request #163952 · rust-lang/rust

yilin0518 · 2026-10-07T15:52:05Z

This PR remove all ignore-tidy-undocumented-unsafe in alloc/src/collections/linked_list.rs. All unsafe call-sites are checked. Besides, this PR adds missing document comments for two unsafe functions(although they are private).

If there exists anything need to be modified, I will update this PR.

rustbot · 2026-10-07T15:52:11Z

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 12 candidates
Random selection from JohnTitor, Mark-Simulacrum, clarfonthey

bushrat011899

Minor nit with the formatting of one particular bit of documentation. This actual safety documentation looks good to me, but I'll leave it to another reviewer to confirm.

View changes since this review

rustbot · 2026-10-08T01:16:56Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

yilin0518 · 2026-10-19T14:48:46Z

@rustbot ready

bushrat011899

Taking another look at this, I believe the safety documentation doesn't quite cover the full breadth of requirements. There might be more as well, but these are what I picked up.

View changes since this review

yilin0518 · 2026-10-21T03:24:07Z

@bushrat011899 thank you very much. I read these codes again and be sure that I was wrong about the index. I update the definition-site doc and the call-site comment. Could you please take another look at it?

yilin0518 · 2026-10-25T14:02:55Z

@rustbot ready

clarfonthey · 2026-10-25T16:18:25Z

r? bushrat011899 since I trust your review here and you can just merge once you're happy with it.

bushrat011899

Thank you so much for all the work you're putting into these docs. I have one last trio of very tiny changes, and then I feel comfortable approving this PR. Since this is exclusively documentation changes I do consider this low-risk, and even potentially incomplete safety documentation is more useful that nothing at all.

View changes since this review

rustbot · 2026-10-26T02:32:47Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

yilin0518 · 2026-10-26T02:34:25Z

@rustbot ready. I have fixed this PR and add the ownership requirement, besides add the deleted blank line. @bushrat011899 thank you for your review!

bushrat011899

Thanks for all your work on this!

~~@bors r?~~

View changes since this review

rust-bors · 2026-10-26T05:06:34Z

Unknown command "r?". Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

bushrat011899 · 2026-10-26T05:07:01Z

@bors r+

rust-bors · 2026-10-26T05:07:05Z

📌 Commit 1da334e has been approved by bushrat011899

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

…hrat011899 Remove ignore-unsafe tidy check in alloc/linklist This PR remove all `ignore-tidy-undocumented-unsafe` in `alloc/src/collections/linked_list.rs`. All unsafe call-sites are checked. Besides, this PR adds missing document comments for two unsafe functions(although they are private). If there exists anything need to be modified, I will update this PR.

…uwer Rollup of 5 pull requests Successful merges: - #164790 (Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`) - #163952 (Remove ignore-unsafe tidy check in alloc/linklist) - #164691 (Minor lints and performance improvements for LLDB visualizers) - #164925 (Cleanup `rustdoc-html` tests) - #164941 (Update actions/setup-python action to v7.1.0)

Rollup merge of #163952 - yilin0518:fix_tidy_linklist, r=bushrat011899 Remove ignore-unsafe tidy check in alloc/linklist This PR remove all `ignore-tidy-undocumented-unsafe` in `alloc/src/collections/linked_list.rs`. All unsafe call-sites are checked. Besides, this PR adds missing document comments for two unsafe functions(although they are private). If there exists anything need to be modified, I will update this PR.

rustbot assigned clarfonthey Oct 7, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 7, 2026

bushrat011899 requested changes Oct 8, 2026

View reviewed changes

Comment thread library/alloc/src/collections/linked_list.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2026

yilin0518 force-pushed the fix_tidy_linklist branch from ec55b97 to d92c37f Compare October 19, 2026 14:47

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2026

bushrat011899 requested changes Oct 19, 2026

View reviewed changes

Comment thread library/alloc/src/collections/linked_list.rs Outdated

Comment thread library/alloc/src/collections/linked_list.rs Outdated

Comment thread library/alloc/src/collections/linked_list.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026

yilin0518 force-pushed the fix_tidy_linklist branch from d92c37f to 443a61d Compare October 20, 2026 07:05

bushrat011899 reviewed Oct 20, 2026

View reviewed changes

Comment thread library/alloc/src/collections/linked_list.rs Outdated

yilin0518 force-pushed the fix_tidy_linklist branch 2 times, most recently from ac8c13e to a381a72 Compare October 21, 2026 03:21

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2026

rustbot assigned bushrat011899 and unassigned clarfonthey Oct 25, 2026

bushrat011899 requested changes Oct 26, 2026

View reviewed changes

Comment thread library/alloc/src/collections/linked_list.rs

Comment thread library/alloc/src/collections/linked_list.rs

Comment thread library/alloc/src/collections/linked_list.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2026

Remove ignore-unsafe tidy check in alloc/linklist

1da334e

yilin0518 force-pushed the fix_tidy_linklist branch from a381a72 to 1da334e Compare October 26, 2026 02:32

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2026

bushrat011899 approved these changes Oct 26, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2026

jhpratt mentioned this pull request Oct 26, 2026

Rollup of 3 pull requests #164959

Closed

This was referenced Oct 26, 2026

Rollup of 6 pull requests #164961

Closed

Rollup of 5 pull requests #164964

Merged

rust-bors Bot merged commit 16728a1 into rust-lang:main Oct 26, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 26, 2026

Conversation

yilin0518 commented Oct 7, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 7, 2026

Uh oh!

bushrat011899 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Oct 8, 2026

Uh oh!

This comment has been minimized.

yilin0518 commented Oct 19, 2026

Uh oh!

bushrat011899 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yilin0518 commented Oct 21, 2026

Uh oh!

yilin0518 commented Oct 25, 2026

Uh oh!

clarfonthey commented Oct 25, 2026

Uh oh!

bushrat011899 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Oct 26, 2026

Uh oh!

yilin0518 commented Oct 26, 2026

Uh oh!

bushrat011899 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

bushrat011899 commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yilin0518 commented Oct 7, 2026 •

edited by rustbot

Loading

bushrat011899 left a comment •

edited by rustbot

Loading

bushrat011899 left a comment •

edited by rustbot

Loading

bushrat011899 left a comment •

edited by rustbot

Loading

bushrat011899 left a comment •

edited

Loading