feat: Diagnose trait errors 🎉#22186
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
2faaf56 to
0785743
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
trait-errors
branch
2 times, most recently
from
5939ef1 to
73dce3f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
73dce3f to
f150647
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
f150647 to
c2ac503
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
c2ac503 to
b84e9b1
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
b84e9b1 to
b113b75
Compare
This comment has been minimized.
This comment has been minimized.
In rustc it is not, but we're unlikely to add something non-`Copy` to it in the near future, and it simplifies the code. This was basically adding a derive then `cargo clippy --fix` and `cargo fmt`.
I.e. type does not implement trait. There are a lot of other solver errors to be emitted, and the error is pretty simple currently, but this is a huge step!
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
b113b75 to
26ae4ac
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
Really exciting, huge progress 🎉
I'm quite sure the implementation is done right, but I delegate the merge at your disposal as you might want second eyes for this or this might cause some false positives so might be a little bit overwhelming to be merged just before the stable release 😅
| } | ||
| "#, | ||
| expect
I.e. type does not implement trait.
There are a lot of other solver errors to be emitted, and the error is pretty simple currently, but this is a huge step!
Watch this wonderful video:
trait.errors.mp4