TypeMismatch quickfix position error: to_owned()#22185
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
removed
the
S-waiting-on-review
WeiTheShinobi
changed the title
to_owned()
WeiTheShinobi
force-pushed
the
fix_type_mismatch_str_ref_to_owned_block_tail_expr
branch
from
65b4fc7 to
94f431c
Compare
|
|
||
| let edit = TextEdit::insert(range.end(), to_owned); | ||
| let mut edit_expr = expr.clone(); | ||
| while let ast::Expr::BlockExpr(block) = edit_expr.clone() { |
There was a problem hiding this comment.
This is not a real fix
We should fix the emit of diagnostic because d: &hir::TypeMismatch<'_> points to { "" } instead of ""
There was a problem hiding this comment.
I moved the logic to where TypeMismatch is created and both cases have been solved,
Or should I fix this further upstream?
rustbot
added
the
S-waiting-on-review
| ExprOrPatId::ExprId(expr) => source_map.expr_syntax(expr).map(Either::Left), | ||
| ExprOrPatId::ExprId(mut expr) => { | ||
| while let Expr::Block { tail: Some(tail), .. } = &body[expr] { | ||
| expr = *tail; |
There was a problem hiding this comment.
@ChayimFriedman2 I don't know if it's appropriate this, do you think?
There was a problem hiding this comment.
I don't think this is the place. If we have adjustments to do and we can't do them when emitting the type mismatch, we should do them in ide-diagnostics.
This comment has been minimized.
This comment has been minimized.
WeiTheShinobi
force-pushed
the
fix_type_mismatch_str_ref_to_owned_block_tail_expr
branch
from
6514fc9 to
4c20a4d
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
the
S-waiting-on-review
WeiTheShinobi
force-pushed
the
fix_type_mismatch_str_ref_to_owned_block_tail_expr
branch
from
739a261 to
4c20a4d
Compare
rustbot
added
the
S-waiting-on-review
| let file_id = d.expr_or_pat.file_id; | ||
| let root = ctx.sema.db.parse_or_expand(file_id); | ||
| let mut expr = expr_ptr.to_node(&root); | ||
| while let ast::Expr::BlockExpr(block) = expr.clone() { |
There was a problem hiding this comment.
I still hope to change fn emit_type_mismatch() or its calling site
4 participants
Fixed #22152