Add zenoh_security_tools#595
Merged
Merged
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Since we have the dependency now via #583, this is a potential improvement to the current string concatenation. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Member
Author
|
CI started with
|
mjcarroll
reviewed
Apr 5, 2025
Member
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
Changes against what was there look good, I haven't tested locally yet. Looks like you are missing CLI11 in the CI run, though? Has something changed because that was working yesterday.
Member
Author
I don't think we ran CI before? We'll need to add CLI11 to the curated list of dependencies for CI jobs in the dockerfile https://github.com/ros2/ci/blob/cab2da7ecea03936e50103df6ee91d9489a2c617/linux_docker_resources/Dockerfile#L55 and in the pixi.toml. I'm actually leaning towards dropping the dependency to avoid the trouble.... |
Signed-off-by: Yadunund <yadunund@gmail.com>
Member
Author
|
CI started with
|
mjcarroll
approved these changes
Apr 6, 2025
This was referenced Apr 7, 2025
Member
Author
|
@Mergifyio backport jazzy humble |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Apr 20, 2025
* Added zenoh_security_configuration_tools package written in cpp Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Added domain id Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Update policy_parser to use nlohmann_json.hpp Since we have the dependency now via #583, this is a potential improvement to the current string concatenation. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Further json changes Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Refactor package to zenoh_security_tools Signed-off-by: Yadunund <yadunund@gmail.com> * Inject certificates if enclaves provided Signed-off-by: Yadunund <yadunund@gmail.com> * Replace existing endpoints with tls instead of hardcoded changes Signed-off-by: Yadunund <yadunund@gmail.com> * Update README.md Signed-off-by: Yadunund <yadunund@gmail.com> * Also generate router config with security Signed-off-by: Yadunund <yadunund@gmail.com> * Drop CLI11 dependency Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> (cherry picked from commit 1dca3c3)
mergify Bot
pushed a commit
that referenced
this pull request
Apr 20, 2025
* Added zenoh_security_configuration_tools package written in cpp Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Added domain id Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Update policy_parser to use nlohmann_json.hpp Since we have the dependency now via #583, this is a potential improvement to the current string concatenation. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Further json changes Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Refactor package to zenoh_security_tools Signed-off-by: Yadunund <yadunund@gmail.com> * Inject certificates if enclaves provided Signed-off-by: Yadunund <yadunund@gmail.com> * Replace existing endpoints with tls instead of hardcoded changes Signed-off-by: Yadunund <yadunund@gmail.com> * Update README.md Signed-off-by: Yadunund <yadunund@gmail.com> * Also generate router config with security Signed-off-by: Yadunund <yadunund@gmail.com> * Drop CLI11 dependency Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> (cherry picked from commit 1dca3c3)
Yadunund
added a commit
that referenced
this pull request
Apr 20, 2025
* Added zenoh_security_configuration_tools package written in cpp Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Added domain id Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> * Update policy_parser to use nlohmann_json.hpp Since we have the dependency now via #583, this is a potential improvement to the current string concatenation. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Further json changes Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Refactor package to zenoh_security_tools Signed-off-by: Yadunund <yadunund@gmail.com> * Inject certificates if enclaves provided Signed-off-by: Yadunund <yadunund@gmail.com> * Replace existing endpoints with tls instead of hardcoded changes Signed-off-by: Yadunund <yadunund@gmail.com> * Update README.md Signed-off-by: Yadunund <yadunund@gmail.com> * Also generate router config with security Signed-off-by: Yadunund <yadunund@gmail.com> * Drop CLI11 dependency Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> (cherry picked from commit 1dca3c3) Co-authored-by: yadunund <yadunund@gmail.com>
Yadunund
added a commit
that referenced
this pull request
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds off #592 to also inject security certificates generated by sros2 into the session and router configs. Takes logic from #412 and adds it to the config files instead.
See README.md for complete instructions on running a talker-listener demo with access control, authentication and encryption.