Bump Zenoh to v1.3.2 and improve e2e reliability with HeartbeatSporadic#591
Merged
Conversation
… recovery for end-to-end reliability
Yadunund
changed the title
Yadunund
approved these changes
Apr 4, 2025
Member
Yadunund
left a comment
Yadunund
left a comment
There was a problem hiding this comment.
Changes look good. Will run CI before merging.
Member
|
Ci started with: https://gist.githubusercontent.com/Yadunund/c4074b12ea5bdedcddae7b60f60c34bc/raw/0a2dfaf7d380d0733c673af4e6f9773e7261fdfd/ros2_ci.repos
|
Member
|
@Mergifyio backport jazzy humble |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
…ic (#591) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960)
mergify Bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
…ic (#591) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960)
This was referenced Apr 4, 2025
Yadunund
pushed a commit
that referenced
this pull request
Apr 5, 2025
…ic (#591) (#593) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960) Co-authored-by: Julien Enoch <[email protected]>
Yadunund
pushed a commit
that referenced
this pull request
Apr 5, 2025
…ic (#591) (#594) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960) Co-authored-by: Julien Enoch <[email protected]>
Contributor
|
Nice to see this is merged! There is only a few days left before the Kilted freeze: https://discourse.ros.org/t/upcoming-rmw-feature-freeze-for-ros-2-kilted-kaiju-on-april-7-2025/43020 Could we get a new release which includes this fix? 🙂 |
Member
|
We are waiting to get #595 before doing a version bump and blooming a release. What's most important before the freeze is getting source code merged into rolling. We can always bloom releases after. In fact, a new rolling version will be bloomed before we can branch to kilted anyways |
This was referenced Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Zenoh to v1.3.2, making the following changes of commit ids:
It includes those notable changes:
Session::close()implementation so it can be safely waited and awaited in `atexit``In addition, the PR also makes the
RELIABLE+TRANSIENT_LOCALPublishers and Subscribers to use the new non periodic last sample miss detection mechanism for Advanced pub/sub. This ensures end-to-end reliability for those topics, and fixes #543.