fix: correct ASSERT_EQ to ASSERT_NE in admittance controller load test (backport #2264)#2338
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jazzy #2338 +/- ##
=======================================
Coverage 84.88% 84.88%
=======================================
Files 154 154
Lines 15378 15378
Branches 1351 1351
=======================================
Hits 13053 13053
Misses 1834 1834
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1258
Problem
The
test_load_controllertest inadmittance_controllerwas usingASSERT_EQto check againstnullptr, which means the test was asserting that the controller fails to load. Since the controller loads successfully with the params file provided, the test was always passing, even though it was checking the wrong condition.Fix
Changed
ASSERT_EQtoASSERT_NEso the test correctly asserts that the controller loaded successfully (i.e. the result is not nullptr).Note:
range_sensor_broadcasteralready has the correctASSERT_NEin its load test and does not need changes.Is this user-facing behavior change?
no
Did you use Generative AI?
no
This is an automatic backport of pull request #2264 done by Mergify.