Skip to content

Remove deprecated odometry reset methods#2252

Merged
christophfroehlich merged 2 commits intoros-controls:masterfrom
kuralme:cleanup-deprecated-reset-odometry
Apr 29, 2026
Merged

Remove deprecated odometry reset methods#2252
christophfroehlich merged 2 commits intoros-controls:masterfrom
kuralme:cleanup-deprecated-reset-odometry

Conversation

@kuralme
Copy link
Copy Markdown
Contributor

@kuralme kuralme commented Mar 28, 2026

Removes deprecated reset_odometry methods that became obsolate with set_odometry additions. Related issue

Note: SteeringOdometry::reset_odometry() removed as well since it has never referenced, and SteeringKinematics::set_odometry() is available now

Signed-off-by: kuralme <kuralme@protonmail.com>
@kuralme kuralme changed the title [DRAFT] Remove deprecated reset methods [DRAFT] Remove deprecated odometry reset methods Mar 28, 2026
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@christophfroehlich christophfroehlich added the hold Holding off merging this PR until some condition label Mar 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.78%. Comparing base (b23af3b) to head (8c58092).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2252      +/-   ##
==========================================
+ Coverage   84.71%   84.78%   +0.06%     
==========================================
  Files         153      153              
  Lines       15317    15302      -15     
  Branches     1331     1331              
==========================================
- Hits        12976    12974       -2     
+ Misses       1853     1841      -12     
+ Partials      488      487       -1     
Flag Coverage Δ
unittests 84.78% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller/include/diff_drive_controller/odometry.hpp 100.00% <ø> (ø)
diff_drive_controller/src/odometry.cpp 54.78% <ø> (+2.28%) ⬆️
...r/include/omni_wheel_drive_controller/odometry.hpp 100.00% <ø> (ø)
omni_wheel_drive_controller/src/odometry.cpp 85.91% <ø> (+4.58%) ⬆️
...eering_controllers_library/steering_kinematics.hpp 100.00% <ø> (ø)
...ng_controllers_library/src/steering_kinematics.cpp 86.28% <ø> (+2.39%) ⬆️
...ring_controllers_library/src/steering_odometry.cpp 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich marked this pull request as ready for review April 28, 2026 19:03
@christophfroehlich christophfroehlich changed the title [DRAFT] Remove deprecated odometry reset methods Remove deprecated odometry reset methods Apr 28, 2026
@github-actions github-actions Bot requested a review from saikishor April 28, 2026 19:04
@christophfroehlich christophfroehlich removed the hold Holding off merging this PR until some condition label Apr 28, 2026
@christophfroehlich christophfroehlich merged commit d81a337 into ros-controls:master Apr 29, 2026
9 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants