[JSB] Remove dynamic_joint_states and use INDIVIDUAL_BEST_EFFORT for interfaces#2187
Conversation
github-actions
Bot
requested review from
Maverobot,
bijoua29,
bmagyar,
destogl and
mamueluth
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2187 +/- ##
==========================================
+ Coverage 85.20% 85.41% +0.20%
==========================================
Files 145 145
Lines 15384 15375 -9
Branches 1322 1314 -8
==========================================
+ Hits 13108 13132 +24
+ Misses 1790 1761 -29
+ Partials 486 482 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Changes LGTM. This is possibly a behavior change, if the urdf does not contain a joint otherwise published with interface_configuration_type::ALL?
At least a hint in the release notes would be great.
Right now, it does use filter URDF joints parameter in doing so. Sure, I can add to the release notes |
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
In file included from /workspaces/ros2_ipc_ws/src/ros2_controllers/joint_state_broadcaster/test/test_joint_state_broadcaster.cpp:32:
/workspaces/ros2_ipc_ws/src/ros2_controllers/joint_state_broadcaster/test/test_joint_state_broadcaster.hpp:57:36: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings]
57 | constexpr char * kThreeJointURDF = R"(
| ^~~
...
---
Finished <<< joint_state_broadcaster [27.1s]
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
christophfroehlich
merged commit 01f6f40
into
ros-controls:master
3 participants
This cleans up the deprecated dynamic joint states and then uses the INDIVIDUAL_BEST_EFFORT part to handle the joint_states topic
NOT TO BE BACKPORTED