Skip to content

[gpio_controllers] Fix crash on NaN state values and sanitize inputs #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ishan1923 wants to merge 17 commits into
base: master
Choose a base branch
from

fix: resolve variable shadowing in apply_command and add boolean test

8f55ee9
Select commit
Loading
Failed to load commit list.
Open

[gpio_controllers] Fix crash on NaN state values and sanitize inputs #2103

fix: resolve variable shadowing in apply_command and add boolean test
8f55ee9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 10, 2026 in 0s

84.88% (+0.11%) compared to 3e66d39

View this Pull Request on Codecov

84.88% (+0.11%) compared to 3e66d39

Details

Codecov Report

❌ Patch coverage is 91.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.88%. Comparing base (3e66d39) to head (8f55ee9).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
gpio_controllers/src/gpio_command_controller.cpp 66.66% 3 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2103      +/-   ##
==========================================
+ Coverage   84.77%   84.88%   +0.11%     
==========================================
  Files         153      153              
  Lines       15236    15126     -110     
  Branches     1322     1304      -18     
==========================================
- Hits        12916    12840      -76     
+ Misses       1838     1815      -23     
+ Partials      482      471      -11
Files with missing lines Coverage Δ
..._controllers/test/test_gpio_command_controller.cpp 99.17% <100.00%> (+0.17%) ⬆️
gpio_controllers/src/gpio_command_controller.cpp 82.74% <66.66%> (-0.78%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov