Repository navigation
ci: run the native engine's unit tests on pull requests into fullnative-dev - #76
Conversation
…ve-dev Nothing built or tested android-native/ in CI, so a native change could only be checked with a local Android toolchain. The native-engine job runs ./gradlew :engine:testDebugUnitTest with JDK 17, the NDK and CMake versions pinned in engine/build.gradle.kts (read from it), the llama.cpp and zstd submodules, and a Gradle cache. It uploads the test report when a test fails.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The app module has no unit tests, so a change to it (ChatViewModel, screens) was checked by nothing. :app:compileDebugKotlin catches code that no longer builds, without the native library build.
|
Approve. Checked locally with #77–#80 merged on top of fullnative-dev (fc6b923): |
CI: run the native engine's unit tests on pull requests into fullnative-dev
Nothing in CI builds or tests
android-native/, so a native change can only be checked by someone with a local Android toolchain. This adds anative-enginejob to.github/workflows/ci.yml:cd android-native && ./gradlew :engine:testDebugUnitTest;fullnative-dev(if: github.base_ref == 'fullnative-dev'); the TypeScript job is unchanged;android-actions/setup-android), and the NDK and CMake versions pinned inengine/build.gradle.kts, read from that file so they can't drift (today NDK 27.1.12297006, CMake 3.22.1);gradle/actions/setup-gradle);engine/build/reports/tests/when a test fails.The job runs on this PR itself, so its result here is the test: it should report the same 99 passing tests as a local run.
I haven't run Gradle locally (no Android toolchain on this machine), and no CodeRabbit CLI review was run before pushing (
crisn't installed here).