Repository navigation
Conversation
android-actions/setup-android@v3 failed before any build: its default packages are "tools platform-tools", and the SDK repository no longer has "tools" (sdkmanager: Failed to find package 'tools', exit code 1). The Ubuntu runner already has the Android SDK, so the job now accepts the licenses and installs the pinned NDK and CMake with $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
The job runs the pull request's Gradle code. permissions: contents: read, and checkout with persist-credentials: false (CodeRabbit review on rferrari#80).
…ngine-sdk # Conflicts: # .github/workflows/ci.yml
bgrana75
changed the title
2 participants
CI: read-only token for the native job, not kept in the checkout
Your
40c2c623fixed thesetup-androidfailure onfullnative-dev(onlyplatform-tools), so this PR no longer changes the SDK step. I mergedfullnative-devin and kept your version.What's left is CodeRabbit's finding from its review of #80: the
native-enginejob runs the pull request's own Gradle code, andactions/checkoutkeepsGITHUB_TOKENin the checkout. Two lines limit that:permissions: contents: readon the job;persist-credentials: falseon the checkout. The submodules are still fetched by the checkout step itself.The job's own run on this PR is the check. No CodeRabbit CLI review was run before pushing (
crisn't installed here).