Skip to content

[v26.1.x] cloud_io: release client lease before retry backoff sleep#30212

Merged
nvartolomei merged 2 commits intoredpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30177-v26.1.x-591
Apr 17, 2026
Merged

[v26.1.x] cloud_io: release client lease before retry backoff sleep#30212
nvartolomei merged 2 commits intoredpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30177-v26.1.x-591

Conversation

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Backport of PR #30177

Acquire the client lease inside the retry loop and explicitly release it
after shutdown, before sleeping for backoff. Previously most methods
acquired the lease once before the loop and held it across all retries,
starving the pool while sleeping.

As a side effect, the retry permit check (which tests the caller's abort
source) now happens before attempting to acquire a client from the pool.

(cherry picked from commit 3911917)
@vbotbuildovich vbotbuildovich added this to the v26.1.x-next milestone Apr 17, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 17, 2026
@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

CI test results

test results on build#83312
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) WriteCachingFailureInjectionE2ETest test_crash_all {"use_transactions": false} integration https://buildkite.com/redpanda/redpanda/builds/83312#019d9bc1-b12b-4c62-bc4d-9ad99a2c194e 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0677, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1897, p1=0.1220, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=WriteCachingFailureInjectionE2ETest&test_method=test_crash_all

@nvartolomei nvartolomei merged commit bc776e0 into redpanda-data:v26.1.x Apr 17, 2026
20 checks passed
@tyson-redpanda tyson-redpanda modified the milestones: v26.1.x-next, v26.1.6 May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants